Обсуждение: Minor Comment updates

Some minor updates to comments.

On Thu, Apr 21, 2005 at 11:15:48PM +0100, Simon Riggs wrote:


This one is wrong ... it really means EXPLAIN EXECUTE.

> Index: explain.c
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/src/backend/commands/explain.c,v
> retrieving revision 1.132
> diff -d -c -r1.132 explain.c
> *** explain.c    16 Apr 2005 20:07:35 -0000    1.132
> --- explain.c    21 Apr 2005 22:07:22 -0000
> ***************
> *** 205,211 ****
>    *        EXPLAIN output
>    *
>    * This is exported because it's called back from prepare.c in the
> !  * EXPLAIN EXECUTE case
>    *
>    * Note: the passed-in QueryDesc is freed when we're done with it
>    */
> --- 205,211 ----
>    *        EXPLAIN output
>    *
>    * This is exported because it's called back from prepare.c in the
> !  * EXPLAIN ANALYZE case
>    *
>    * Note: the passed-in QueryDesc is freed when we're done with it
>    */

--
Alvaro Herrera (<alvherre[@]dcc.uchile.cl>)
Essentially, you're proposing Kevlar shoes as a solution for the problem
that you want to walk around carrying a loaded gun aimed at your foot.
(Tom Lane)

On Thu, 2005-04-21 at 23:52 -0400, Alvaro Herrera wrote:
> On Thu, Apr 21, 2005 at 11:15:48PM +0100, Simon Riggs wrote:
>
>
> This one is wrong ... it really means EXPLAIN EXECUTE.
>

OK, yes that one is wrong - thought it was old syntax.

Best Regards, Simon Riggs

On Thu, 2005-04-21 at 23:52 -0400, Alvaro Herrera wrote:
> On Thu, Apr 21, 2005 at 11:15:48PM +0100, Simon Riggs wrote:

> This one is wrong ... it really means EXPLAIN EXECUTE.
>

An updated patch, with changes to nodeAppend.c and nodeResult.c (only)

These are the only two files in /executor that have old QUEL comments in
to describe their behaviour, AFAICS.

Best Regards, Simon Riggs

Simon Riggs wrote:
> These are the only two files in /executor that have old QUEL comments in
> to describe their behaviour, AFAICS.

Applied with some minor cleanups. Thanks for the patch.

-Neil

Neil Conway <neilc@samurai.com> writes:
> Simon Riggs wrote:
>> These are the only two files in /executor that have old QUEL comments in
>> to describe their behaviour, AFAICS.

> Applied with some minor cleanups. Thanks for the patch.

I restored the one example Simon removed, as I think it's a useful
example:

*** 10,15 ****
--- 10,20 ----
   *
   *                select 1 * 2
   *
+  *                insert into emp values ('mike', 15000)
+  *
+  *        (Remember that in an INSERT or UPDATE, we need a plan tree that
+  *        generates the new rows.)
+  *
   *        Result nodes are also used to optimise queries with constant
   *        qualifications (ie, quals that do not depend on the scanned data),
   *        such as:

            regards, tom lane