Обсуждение: Buildfarm test failure

The buildfarm failed last night whilst performing the JDK 5 builds:

testjar:
     [mkdir] Created dir: /home/ubuntu/buildarea/HEAD/pgjdbc/build/tests
     [javac] /home/ubuntu/buildarea/HEAD/pgjdbc/build.xml:399: warning:
'includeantruntime' was not set, defaulting to build.sysclasspath=last;
set to false for repeatable builds
     [javac] Compiling 58 source files to
/home/ubuntu/buildarea/HEAD/pgjdbc/build/tests
     [javac]
/home/ubuntu/buildarea/HEAD/pgjdbc/org/postgresql/test/jdbc2/ArrayTest.java:213:
cannot find symbol
     [javac] symbol  : method
createArrayOf(java.lang.String,java.lang.String[])
     [javac] location: interface java.sql.Connection
     [javac]         Array sqlArray = conn.createArrayOf("text", strArray);
     [javac]                              ^
     [javac] Note: Some input files use or override a deprecated API.
     [javac] Note: Recompile with -Xlint:deprecation for details.
     [javac] Note: Some input files use unchecked or unsafe operations.
     [javac] Note: Recompile with -Xlint:unchecked for details.
     [javac] 1 error

I've done some digging and it appears that a test of a JDBC4 method has
ended up in the JDBC2 test suite. I've attached a patch that removes the
offending test and there is no need to add it to the corresponding JDBC4
tests as it is already present.

Kind regards,
--
Mike Fowler
Registered Linux user: 379787

Dave,

Confirmed - the buildfarm is now building cleanly for all builds.

Kind regards,

--
Mike Fowler
Registered Linux user: 379787


> Mike,
>
> Again, thanks
>
> Fixed.
>
>
> Dave Cramer
>
> dave.cramer(at)credativ(dot)ca
> http://www.credativ.ca
>
>
>
> On Thu, Nov 1, 2012 at 5:01 PM, Dave Cramer <pg@fastcrypt.com> wrote:
>
>> Ya, that's my ineptitude with git showing through.
>>
>> The buildfarm is a good thing.
>>
>> Thanks
>>
>> Dave
>>
>> Dave Cramer
>>
>> dave.cramer(at)credativ(dot)ca
>> http://www.credativ.ca
>>
>>
>>
>> On Thu, Nov 1, 2012 at 4:52 PM, Mike Fowler <mike@mlfowler.com> wrote:
>>
>>> The buildfarm failed last night whilst performing the JDK 5 builds:
>>>
>>> testjar:
>>>     [mkdir] Created dir:
>>> /home/ubuntu/buildarea/HEAD/**pgjdbc/build/tests
>>>     [javac] /home/ubuntu/buildarea/HEAD/**pgjdbc/build.xml:399:
>>> warning:
>>> 'includeantruntime' was not set, defaulting to build.sysclasspath=last;
>>> set
>>> to false for repeatable builds
>>>     [javac] Compiling 58 source files to /home/ubuntu/buildarea/HEAD/**
>>> pgjdbc/build/tests
>>>     [javac]
>>> /home/ubuntu/buildarea/HEAD/**pgjdbc/org/postgresql/test/**jdbc2/ArrayTest.java:213:
>>> cannot find symbol
>>>     [javac] symbol  : method createArrayOf(java.lang.**
>>> String,java.lang.String[])
>>>     [javac] location: interface java.sql.Connection
>>>     [javac]         Array sqlArray = conn.createArrayOf("text",
>>> strArray);
>>>     [javac]                              ^
>>>     [javac] Note: Some input files use or override a deprecated API.
>>>     [javac] Note: Recompile with -Xlint:deprecation for details.
>>>     [javac] Note: Some input files use unchecked or unsafe operations.
>>>     [javac] Note: Recompile with -Xlint:unchecked for details.
>>>     [javac] 1 error
>>>
>>> I've done some digging and it appears that a test of a JDBC4 method has
>>> ended up in the JDBC2 test suite. I've attached a patch that removes
>>> the
>>> offending test and there is no need to add it to the corresponding
>>> JDBC4
>>> tests as it is already present.
>>>
>>> Kind regards,
>>> --
>>> Mike Fowler
>>> Registered Linux user: 379787
>>>
>>>
>>> --
>>> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgsql-jdbc
>>>
>>>
>>
>

On 11/02/2012 04:52 AM, Mike Fowler wrote:
> The buildfarm failed last night whilst performing the JDK 5 builds:
>
> testjar:
>     [mkdir] Created dir: /home/ubuntu/buildarea/HEAD/pgjdbc/build/tests
>     [javac] /home/ubuntu/buildarea/HEAD/pgjdbc/build.xml:399: warning:
> 'includeantruntime' was not set, defaulting to
> build.sysclasspath=last; set to false for repeatable builds
>     [javac] Compiling 58 source files to
> /home/ubuntu/buildarea/HEAD/pgjdbc/build/tests
>     [javac]
> /home/ubuntu/buildarea/HEAD/pgjdbc/org/postgresql/test/jdbc2/ArrayTest.java:213:
> cannot find symbol
>     [javac] symbol  : method
> createArrayOf(java.lang.String,java.lang.String[])
>     [javac] location: interface java.sql.Connection
>     [javac]         Array sqlArray = conn.createArrayOf("text", strArray);

That was a mistake I introduced in a patch ages ago, but it should not
appear in any public history, so I'm confused about how it made it to
the buildfarm, let alone now.

--
Craig Ringer