Обсуждение: Re: JDBC specific Buildfarm member
On 05/04/2011 05:17 PM, Mike Fowler wrote:
> Hi Andrew/Alvaro,
>
> I've just received the animal "piapiac" for my buildfarm which will
> run for 8.4, 9.0 and HEAD. I've created a JDBC module which is invoked
> during the locale testing once the database is running. It's activated
> by a new configuration parameter in build-farm.conf (set to undef in
> the attached patch). When invoked the module updates the JDBC source,
> builds and runs the tests for jdks 4, 5 and 6. In order to report the
> distinct JDBC failures I've added the following "stages" for the
> purposes of the send_result function:
>
> JDBC-CVS - SCM related problems, the JDBC code is in CVS
> JDBC-Clean - clearing out the previous build fails
> JDBC-JDK - the JDK's configuration is incorrect
> JDBC-Build - compiler failures
> JDBC-Create - creating the test user/database/lang failed
> JDBC-Test-Config - creating the overridden properties for the JUnit
> failed
> JDBC-Test - any JUnit failures/errors
> JDBC-Drop- dropping the test database/user failed
>
> Currently the module assumes that Apache ant is installed and the the
> JUnit jar file resides in the path - on Ubuntu it's simply "sudo
> apt-get install ant junit".
>
> The JDBC module isn't complete and could do with some more tweaks, but
> it is running and I've been able to test most of the failure
> conditions locally. Of course things might be different in the "wild".
> A couple of sore thumbs that stick out is that the JDBC specific
> configuration (e.g. the paths to the jdks) is baked in to the module
> and the JDBC suite is run for each locale which may be overkill. I'll
> continue to refine and provide you patches if you're interested in the
> code.
>
> As I'm running this one of the "free" Amazon EC2 micro instances I've
> got it configured to run one of the three development branches every 8
> hours (HEAD,REL9_0_STABLE,REL8_4_STABLE) with all three JDKs being
> tested with fresh code from the JDBC repo each time. Hopefully I'll
> remain within my free usage!
>
> If you're happy with this I will enable my buildfarm member.
This looks pretty good.
You should probably fill in $steps_completed. You'd need to change its
declaration so it was visible - change it so the declarations is :
use vars qw($steps_completed);
As a matter of style, I stopped using globs for file handles long ago,
in favor of local variables. It would be best to keep to that style for
consistency (although you've done a pretty good job on that front, I
must say.)
Go ahead and enable it and let's see the results on the server.
Maybe I should factor out the core tests in a similar fashion.
Nice work.
cheers
andrew
Excerpts from Andrew Dunstan's message of mié may 04 19:17:44 -0300 2011: > > On 05/04/2011 05:17 PM, Mike Fowler wrote: > > I've just received the animal "piapiac" for my buildfarm which will > > run for 8.4, 9.0 and HEAD. > > This looks pretty good. I wish there was a way for buildfarm member owners to send a comment to the animal-creating slave (me in this case). If I had knew it was a JDBC-related thing I would have chosen a Java-related animal. Just sayin'. > Nice work. Yeah :-) -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support
On 05/04/2011 06:39 PM, Alvaro Herrera wrote: > Excerpts from Andrew Dunstan's message of mié may 04 19:17:44 -0300 2011: >> On 05/04/2011 05:17 PM, Mike Fowler wrote: >>> I've just received the animal "piapiac" for my buildfarm which will >>> run for 8.4, 9.0 and HEAD. >> This looks pretty good. > I wish there was a way for buildfarm member owners to send a comment to > the animal-creating slave (me in this case). If I had knew it was a > JDBC-related thing I would have chosen a Java-related animal. > > Just sayin'. Well, it's off topic, but we can certainly add something to the registration form pretty easily. cheers andrew
On 04/05/11 23:17, Andrew Dunstan wrote: > > > This looks pretty good. > > You should probably fill in $steps_completed. You'd need to change its > declaration so it was visible - change it so the declarations is : > > use vars qw($steps_completed); > > As a matter of style, I stopped using globs for file handles long ago, > in favor of local variables. It would be best to keep to that style for > consistency (although you've done a pretty good job on that front, I > must say.) > > Go ahead and enable it and let's see the results on the server. > > Maybe I should factor out the core tests in a similar fashion. > > Nice work. > > cheers > > andrew > > > Thanks, I've switched it on and 8.4 has been building for the last little while so we should see some results in a hour or so. I'll try and make your suggested changes and send a revised patch over the weekend. On the subject of refactoring, at some point it might be in idea to change the SCM module so that it's project agnostic. Once that's done I can drop the CVS handling in the JDBC module. Regards, -- Mike Fowler Registered Linux user: 379787
On 05/05/2011 01:49 AM, Mike Fowler wrote: > > > Thanks, I've switched it on and 8.4 has been building for the last > little while so we should see some results in a hour or so. I'll try > and make your suggested changes and send a revised patch over the > weekend. I can't see any results on the buildfarm server. > > On the subject of refactoring, at some point it might be in idea to > change the SCM module so that it's project agnostic. Once that's done > I can drop the CVS handling in the JDBC module. Good idea. cheers andrew
On 05/05/11 16:26, Andrew Dunstan wrote: > > > On 05/05/2011 01:49 AM, Mike Fowler wrote: >> >> >> Thanks, I've switched it on and 8.4 has been building for the last >> little while so we should see some results in a hour or so. I'll try >> and make your suggested changes and send a revised patch over the >> weekend. > > > I can't see any results on the buildfarm server. It seems I had the aux_path set incorrectly as it failed to run the run_web_txn.pl. I'm home from work now so I can keep a closer eye on things this evening. Regards, -- Mike Fowler Registered Linux user: 379787
On 05/05/11 21:04, Mike Fowler wrote: > On 05/05/11 16:26, Andrew Dunstan wrote: >> >> >> On 05/05/2011 01:49 AM, Mike Fowler wrote: >>> >>> >>> Thanks, I've switched it on and 8.4 has been building for the last >>> little while so we should see some results in a hour or so. I'll try >>> and make your suggested changes and send a revised patch over the >>> weekend. >> >> >> I can't see any results on the buildfarm server. > > It seems I had the aux_path set incorrectly as it failed to run the > run_web_txn.pl. I'm home from work now so I can keep a closer eye on > things this evening. > 8.4 was successfully build in the wee hours of my morning and is visible at http://www.pgbuildfarm.org/cgi-bin/show_status.pl. The JDBC logs are with all the other logs and I note that it's only the last JDK that is in the logs. I shall change that too so that the logs for each JDK is independent. 9.0 is currently building. Regards, -- Mike Fowler Registered Linux user: 379787
Excerpts from Andrew Dunstan's message of mié may 04 19:50:51 -0300 2011: > On 05/04/2011 06:39 PM, Alvaro Herrera wrote: > > I wish there was a way for buildfarm member owners to send a comment to > > the animal-creating slave (me in this case). If I had knew it was a > > JDBC-related thing I would have chosen a Java-related animal. > > > > Just sayin'. > > Well, it's off topic, but we can certainly add something to the > registration form pretty easily. Yeah that'd be great. It might even save the animal-creator some time if he/she doesn't have to go hunting for an animal name. BTW would it be worth displaying a Java related icon in the flags column of the dashboard? There are a few here http://findicons.com/search/powered-by-java Maybe http://findicons.com/icon/51582/java?width=16 -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support