Re: [BUGS] BUG #4941: pg_stat_statements crash

Re: [BUGS] BUG #4941: pg_stat_statements crash

Re: [BUGS] BUG #4941: pg_stat_statements crash

Re: [BUGS] BUG #4941: pg_stat_statements crash

Tom Lane  wrote:

> > We should call [Read dumpfile] routine only once even on Windows.
> Seems to me that you should simply do the load only when found is false.

Here is a patch to fix pg_stat_statements on Windows.

I see we don't need any locks because initialization is done in postmaster;
There are no chance to see uninitialized state of 'pgss' after relasing
AddinShmemInitLock and before load dumpfile into it.

I also check pgss_shmem_shutdown and no problem.
It is called only once from postmaster on shutdown.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

Re: [BUGS] BUG #4941: pg_stat_statements crash

Re: [BUGS] BUG #4941: pg_stat_statements crash

Re: [BUGS] BUG #4941: pg_stat_statements crash