Re: [BUGS] BUG #4941: pg_stat_statements crash

Поиск
Список
Период
Сортировка
От Itagaki Takahiro
Тема Re: [BUGS] BUG #4941: pg_stat_statements crash
Дата
Msg-id 20090727114035.E3D2.52131E4D@oss.ntt.co.jp
обсуждение исходный текст
Ответы Re: [BUGS] BUG #4941: pg_stat_statements crash  (Alvaro Herrera <alvherre@commandprompt.com>)
Re: [BUGS] BUG #4941: pg_stat_statements crash  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> wrote:

> > We should call [Read dumpfile] routine only once even on Windows.
> Seems to me that you should simply do the load only when found is false.

Here is a patch to fix pg_stat_statements on Windows.

I see we don't need any locks because initialization is done in postmaster;
There are no chance to see uninitialized state of 'pgss' after relasing
AddinShmemInitLock and before load dumpfile into it.

I also check pgss_shmem_shutdown and no problem.
It is called only once from postmaster on shutdown.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: generic explain options v3
Следующее
От: Robert Haas
Дата:
Сообщение: Re: autogenerating headers & bki stuff