Обсуждение: poor wording on SSPI error message
Hi, This message r = (_QuerySecurityContextToken) (sspictx, &token); if (r != SEC_E_OK) { FreeLibrary(secur32); pg_SSPI_error(ERROR, gettext_noop("could not get security token from context"), r); } looks poorly worded. What "context" is it talking about? Can we be a bit more explicit? Any other thoughts on how to improve it? -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Alvaro Herrera wrote: > Hi, > > This message > > r = (_QuerySecurityContextToken) (sspictx, &token); > if (r != SEC_E_OK) > { > FreeLibrary(secur32); > pg_SSPI_error(ERROR, > gettext_noop("could not get security token from context"), r); > } > > looks poorly worded. What "context" is it talking about? Can we be a > bit more explicit? Any other thoughts on how to improve it? Hmm. that should probalby read "could not get token from security context", because that's what it's trying to do. But maybe you meant something different from that as well? /Magnus
Magnus Hagander <magnus@hagander.net> writes: > Alvaro Herrera wrote: >>> gettext_noop("could not get security token from context"), r); >> >> looks poorly worded. What "context" is it talking about? Can we be a >> bit more explicit? Any other thoughts on how to improve it? > Hmm. that should probalby read "could not get token from security > context", because that's what it's trying to do. But maybe you meant > something different from that as well? I changed this to "could not get token from SSPI security context", since that term was already in use in a nearby error message. I also fixed a couple of other issues in the same area --- in particular, the messages wouldn't have gotten translated ... regards, tom lane