Обсуждение: Compiler warning in ecpglib/execute.c

Поиск
Список
Период
Сортировка

Compiler warning in ecpglib/execute.c

От
Tom Lane
Дата:
CVS HEAD is producing

execute.c: In function 'ecpg_store_result':
execute.c:394: warning: 'act_tuple' may be used uninitialized in this function

It looks to me like this is an actual bug, not just the compiler being
insufficiently smart to prove the variable is set before use.
        regards, tom lane


Re: Compiler warning in ecpglib/execute.c

От
Michael Meskes
Дата:
On Mon, Feb 02, 2009 at 02:56:18PM -0500, Tom Lane wrote:
> CVS HEAD is producing
> ...

Thanks for the note, I missed this copy&paste error of mine. Fixed in HEAD.
This should alos make the buildfarm green again.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!


Re: Compiler warning in ecpglib/execute.c

От
Alvaro Herrera
Дата:
Michael Meskes wrote:
> On Mon, Feb 02, 2009 at 02:56:18PM -0500, Tom Lane wrote:
> > CVS HEAD is producing
> > ...
> 
> Thanks for the note, I missed this copy&paste error of mine. Fixed in HEAD.
> This should alos make the buildfarm green again.

Note that spoonbill is still red.  This animal is special because it
uses some peculiar malloc flags.

-- 
Alvaro Herrera                        http://www.advogato.org/person/alvherre
"La persona que no quería pecar / estaba obligada a sentarseen duras y empinadas sillas    / desprovistas, por ciertode
blandosatenuantes"                          (Patricio Vogel)
 


Re: Compiler warning in ecpglib/execute.c

От
Michael Meskes
Дата:
On Tue, Feb 03, 2009 at 04:06:39PM -0300, Alvaro Herrera wrote:
> Note that spoonbill is still red.  This animal is special because it
> uses some peculiar malloc flags.

Not just spoonbill, five of them are. Without access to a failing machine this
is difficult to debug. I found some missing error checks in that library that
might explain the segfaults, but I still don't see why the the test is failing.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!