Обсуждение: Suggestion for MSVC build
<div class="Section1"><p class="MsoNormal">It seems like there isn’t any good reason the perl scripts for the MSVC builddon’t support readline<p class="MsoNormal"> <p class="MsoNormal">Readline for windows is available as part of the GnuWin32project. <p class="MsoNormal"> <p class="MsoNormal"><a href="http://gnuwin32.sourceforge.net/packages/readline.htm">http://gnuwin32.sourceforge.net/packages/readline.htm</a><p class="MsoNormal"> <pclass="MsoNormal">It normally installs to “c:\Program Files\GnuWin32"<p class="MsoNormal"> <p class="MsoNormal">I’dupdate the scripts myself, but I’m not a PERL programmer.<p class="MsoNormal">From what I can see, you’dadd another line to config.pl for readline, and then add some stuff to mkvcbuild.pm for psql to do something like:<pclass="MsoNormal"> <p class="MsoNormal">if ($solution->{options}->{readline})<p class="MsoNormal"> {<p class="MsoNormal"> $psql->AddIncludeDir($solution->{options}->{readline} . '\include');<pclass="MsoNormal"> $psql->AddLibrary($solution->{options}->{readline}. '\lib\readline.lib');<p class="MsoNormal"> $psql->AddLibrary($solution->{options}->{readline} . '\lib\history.lib');<pclass="MsoNormal">}<p class="MsoNormal"> <p class="MsoNormal">And something to solution.pm in the partthat builds pg_config.h that looks something like:<p class="MsoNormal"> <p class="MsoNormal">if ($self->{options}->{readline})<pclass="MsoNormal"> {<p class="MsoNormal"> print O "#define HAVE_LIBREADLINE 1\n";<p class="MsoNormal"> print O "#define HAVE_READLINE_READLINE_H 1\n";<p class="MsoNormal"> print O "#define HAVE_READLINE_HISTORY_H 1\n";<p class="MsoNormal"> print O "#define USE_READLINE 1\n";<p class="MsoNormal"> print O "#define USE_READLINE_STATIC 1\n";<p class="MsoNormal"> }<p class="MsoNormal">(Not sure about the last line).<p class="MsoNormal"> <pclass="MsoNormal">I don’t know if this is a good idea, but I would think this would make psql more “user-friendly”on windows.<p class="MsoNormal"> <p class="MsoNormal">Perhaps someone who understands readline and perl betterthan me might want to take this on?<p class="MsoNormal"> </div>
What version readline are you using? I tried with the latest download, and I get about 200 warnings like: 1>.\src\bin\psql\tab-complete.c(600) : warning C4013: 'completion_matches' undef ined; assuming extern returning int 1>.\src\bin\psql\tab-complete.c(600) : warning C4047: '=' : 'char **' differs inlevels of indirection from 'int' And also, 12 linker errors - pretty much all the readline stuff. A quick look at the files seem to show that the readline.lib and history.lib files that ship with gnuwin32 are empty of symbols. The .def files are also empty. Are yours different? Also, do you know if this version of readline actually works on non-US locales, or if it's still broken there? (I'd test it myself if I could just build it :-P) //Magnus On Sun, Sep 23, 2007 at 10:03:09PM -0400, Chuck McDevitt wrote: > It seems like there isn't any good reason the perl scripts for the MSVC > build don't support readline > > > > Readline for windows is available as part of the GnuWin32 project. > > > > http://gnuwin32.sourceforge.net/packages/readline.htm > > > > It normally installs to "c:\Program Files\GnuWin32" > > > > I'd update the scripts myself, but I'm not a PERL programmer. > > From what I can see, you'd add another line to config.pl for readline, > and then add some stuff to mkvcbuild.pm for psql to do something like: > > > > if ($solution->{options}->{readline}) > > { > > > $psql->AddIncludeDir($solution->{options}->{readline} . '\include'); > > > $psql->AddLibrary($solution->{options}->{readline} . > '\lib\readline.lib'); > > > $psql->AddLibrary($solution->{options}->{readline} . > '\lib\history.lib'); > > } > > > > And something to solution.pm in the part that builds pg_config.h that > looks something like: > > > > if ($self->{options}->{readline}) > > { > > print O "#define > HAVE_LIBREADLINE 1\n"; > > print O "#define > HAVE_READLINE_READLINE_H 1\n"; > > print O "#define > HAVE_READLINE_HISTORY_H 1\n"; > > print O "#define > USE_READLINE 1\n"; > > print O "#define > USE_READLINE_STATIC 1\n"; > > } > > (Not sure about the last line). > > > > I don't know if this is a good idea, but I would think this would make > psql more "user-friendly" on windows. > > > > Perhaps someone who understands readline and perl better than me might > want to take this on? > > >
Sorry, completion_matches hasn't existed in readline for a long time. You need to define: #define HAVE_RL_COMPLETION_APPEND_CHARACTER 1 #define HAVE_RL_COMPLETION_MATCHES 1 #define HAVE_RL_FILENAME_COMPLETION_FUNCTION 1 Just like we do on Linux. > -----Original Message----- > From: Magnus Hagander [mailto:magnus@hagander.net] > Sent: Monday, September 24, 2007 1:30 AM > To: Chuck McDevitt > Cc: pgsql-hackers@postgresql.org > Subject: Re: [HACKERS] Suggestion for MSVC build > > What version readline are you using? > > I tried with the latest download, and I get about 200 warnings like: > 1>.\src\bin\psql\tab-complete.c(600) : warning C4013: > 'completion_matches' > undef > ined; assuming extern returning int > 1>.\src\bin\psql\tab-complete.c(600) : warning C4047: '=' : 'char **' > differs in > levels of indirection from 'int' > > > And also, 12 linker errors - pretty much all the readline stuff. A > quick > look at the files seem to show that the readline.lib and history.lib > files > that ship with gnuwin32 are empty of symbols. The .def files are also > empty. Are yours different? > > > Also, do you know if this version of readline actually works on non-US > locales, or if it's still broken there? (I'd test it myself if I could > just > build it :-P) > > //Magnus > > On Sun, Sep 23, 2007 at 10:03:09PM -0400, Chuck McDevitt wrote: > > It seems like there isn't any good reason the perl scripts for the > MSVC > > build don't support readline > > > > > > > > Readline for windows is available as part of the GnuWin32 project. > > > > > > > > http://gnuwin32.sourceforge.net/packages/readline.htm > > > > > > > > It normally installs to "c:\Program Files\GnuWin32" > > > > > > > > I'd update the scripts myself, but I'm not a PERL programmer. > > > > From what I can see, you'd add another line to config.pl for > readline, > > and then add some stuff to mkvcbuild.pm for psql to do something > like: > > > > > > > > if ($solution->{options}->{readline}) > > > > { > > > > > > $psql->AddIncludeDir($solution->{options}->{readline} . '\include'); > > > > > > $psql->AddLibrary($solution->{options}->{readline} . > > '\lib\readline.lib'); > > > > > > $psql->AddLibrary($solution->{options}->{readline} . > > '\lib\history.lib'); > > > > } > > > > > > > > And something to solution.pm in the part that builds pg_config.h that > > looks something like: > > > > > > > > if ($self->{options}->{readline}) > > > > { > > > > print O "#define > > HAVE_LIBREADLINE 1\n"; > > > > print O "#define > > HAVE_READLINE_READLINE_H 1\n"; > > > > print O "#define > > HAVE_READLINE_HISTORY_H 1\n"; > > > > print O "#define > > USE_READLINE 1\n"; > > > > print O "#define > > USE_READLINE_STATIC 1\n"; > > > > } > > > > (Not sure about the last line). > > > > > > > > I don't know if this is a good idea, but I would think this would > make > > psql more "user-friendly" on windows. > > > > > > > > Perhaps someone who understands readline and perl better than me > might > > want to take this on? > > > > > >
Also, I think I told you the wrong file to link to. I think it is the .a files, not the .lib files. Let me check on that. > -----Original Message----- > From: Chuck McDevitt > Sent: Monday, September 24, 2007 10:34 AM > To: 'Magnus Hagander' > Cc: pgsql-hackers@postgresql.org > Subject: RE: [HACKERS] Suggestion for MSVC build > > Sorry, completion_matches hasn't existed in readline for a long time. > > You need to define: > > #define HAVE_RL_COMPLETION_APPEND_CHARACTER 1 > #define HAVE_RL_COMPLETION_MATCHES 1 > #define HAVE_RL_FILENAME_COMPLETION_FUNCTION 1 > > Just like we do on Linux. > > > > -----Original Message----- > > From: Magnus Hagander [mailto:magnus@hagander.net] > > Sent: Monday, September 24, 2007 1:30 AM > > To: Chuck McDevitt > > Cc: pgsql-hackers@postgresql.org > > Subject: Re: [HACKERS] Suggestion for MSVC build > > > > What version readline are you using? > > > > I tried with the latest download, and I get about 200 warnings like: > > 1>.\src\bin\psql\tab-complete.c(600) : warning C4013: > > 'completion_matches' > > undef > > ined; assuming extern returning int > > 1>.\src\bin\psql\tab-complete.c(600) : warning C4047: '=' : 'char **' > > differs in > > levels of indirection from 'int' > > > > > > And also, 12 linker errors - pretty much all the readline stuff. A > > quick > > look at the files seem to show that the readline.lib and history.lib > > files > > that ship with gnuwin32 are empty of symbols. The .def files are also > > empty. Are yours different? > > > > > > Also, do you know if this version of readline actually works on non- > US > > locales, or if it's still broken there? (I'd test it myself if I > could > > just > > build it :-P) > > > > //Magnus > > > > On Sun, Sep 23, 2007 at 10:03:09PM -0400, Chuck McDevitt wrote: > > > It seems like there isn't any good reason the perl scripts for the > > MSVC > > > build don't support readline > > > > > > > > > > > > Readline for windows is available as part of the GnuWin32 project. > > > > > > > > > > > > http://gnuwin32.sourceforge.net/packages/readline.htm > > > > > > > > > > > > It normally installs to "c:\Program Files\GnuWin32" > > > > > > > > > > > > I'd update the scripts myself, but I'm not a PERL programmer. > > > > > > From what I can see, you'd add another line to config.pl for > > readline, > > > and then add some stuff to mkvcbuild.pm for psql to do something > > like: > > > > > > > > > > > > if ($solution->{options}->{readline}) > > > > > > { > > > > > > > > > $psql->AddIncludeDir($solution->{options}->{readline} . > '\include'); > > > > > > > > > $psql->AddLibrary($solution->{options}->{readline} . > > > '\lib\readline.lib'); > > > > > > > > > $psql->AddLibrary($solution->{options}->{readline} . > > > '\lib\history.lib'); > > > > > > } > > > > > > > > > > > > And something to solution.pm in the part that builds pg_config.h > that > > > looks something like: > > > > > > > > > > > > if ($self->{options}->{readline}) > > > > > > { > > > > > > print O "#define > > > HAVE_LIBREADLINE 1\n"; > > > > > > print O "#define > > > HAVE_READLINE_READLINE_H 1\n"; > > > > > > print O "#define > > > HAVE_READLINE_HISTORY_H 1\n"; > > > > > > print O "#define > > > USE_READLINE 1\n"; > > > > > > print O "#define > > > USE_READLINE_STATIC 1\n"; > > > > > > } > > > > > > (Not sure about the last line). > > > > > > > > > > > > I don't know if this is a good idea, but I would think this would > > make > > > psql more "user-friendly" on windows. > > > > > > > > > > > > Perhaps someone who understands readline and perl better than me > > might > > > want to take this on? > > > > > > > > >
The right lib files to link readline are the .a ones...
Like this:
if ($solution->{options}->{readline}) { $psql->AddIncludeDir($solution->{options}->{readline} .
'\include'); $psql->AddLibrary($solution->{options}->{readline} .
'\lib\libreadline.dll.a'); $psql->AddLibrary($solution->{options}->{readline} .
'\lib\libhistory.dll.a'); }
For using readline out of the dll. I assume libreadline.a and
libhistory.a instead for static linking.
> -----Original Message-----
> From: Magnus Hagander [mailto:magnus@hagander.net]
> Sent: Monday, September 24, 2007 1:30 AM
> To: Chuck McDevitt
> Cc: pgsql-hackers@postgresql.org
> Subject: Re: [HACKERS] Suggestion for MSVC build
>
> What version readline are you using?
>
> I tried with the latest download, and I get about 200 warnings like:
> 1>.\src\bin\psql\tab-complete.c(600) : warning C4013:
> 'completion_matches'
> undef
> ined; assuming extern returning int
> 1>.\src\bin\psql\tab-complete.c(600) : warning C4047: '=' : 'char **'
> differs in
> levels of indirection from 'int'
>
>
> And also, 12 linker errors - pretty much all the readline stuff. A
> quick
> look at the files seem to show that the readline.lib and history.lib
> files
> that ship with gnuwin32 are empty of symbols. The .def files are also
> empty. Are yours different?
>
>
> Also, do you know if this version of readline actually works on non-US
> locales, or if it's still broken there? (I'd test it myself if I could
> just
> build it :-P)
>
> //Magnus
>
> On Sun, Sep 23, 2007 at 10:03:09PM -0400, Chuck McDevitt wrote:
> > It seems like there isn't any good reason the perl scripts for the
> MSVC
> > build don't support readline
> >
> >
> >
> > Readline for windows is available as part of the GnuWin32 project.
> >
> >
> >
> > http://gnuwin32.sourceforge.net/packages/readline.htm
> >
> >
> >
> > It normally installs to "c:\Program Files\GnuWin32"
> >
> >
> >
> > I'd update the scripts myself, but I'm not a PERL programmer.
> >
> > From what I can see, you'd add another line to config.pl for
> readline,
> > and then add some stuff to mkvcbuild.pm for psql to do something
> like:
> >
> >
> >
> > if ($solution->{options}->{readline})
> >
> > {
> >
> >
> > $psql->AddIncludeDir($solution->{options}->{readline} . '\include');
> >
> >
> > $psql->AddLibrary($solution->{options}->{readline} .
> > '\lib\readline.lib');
> >
> >
> > $psql->AddLibrary($solution->{options}->{readline} .
> > '\lib\history.lib');
> >
> > }
> >
> >
> >
> > And something to solution.pm in the part that builds pg_config.h
that
> > looks something like:
> >
> >
> >
> > if ($self->{options}->{readline})
> >
> > {
> >
> > print O "#define
> > HAVE_LIBREADLINE 1\n";
> >
> > print O "#define
> > HAVE_READLINE_READLINE_H 1\n";
> >
> > print O "#define
> > HAVE_READLINE_HISTORY_H 1\n";
> >
> > print O "#define
> > USE_READLINE 1\n";
> >
> > print O "#define
> > USE_READLINE_STATIC 1\n";
> >
> > }
> >
> > (Not sure about the last line).
> >
> >
> >
> > I don't know if this is a good idea, but I would think this would
> make
> > psql more "user-friendly" on windows.
> >
> >
> >
> > Perhaps someone who understands readline and perl better than me
> might
> > want to take this on?
> >
> >
> >
Actually, the more I look at it, I realize it was correct before
We want to link against readline.lib and history.lib, but the ones in
the GnuWin32 distribution are broken.
The .lib files are made from the .def files, which are supposed to list
the exports, but don't.
They can be made from commands like this:
lib /machine:i386 /def:readline.def
lib /machine:i386 /def:history.def
But that only works if the .def files list the routines you want
exported.
It's easy enough to add the few we use by hand, but I'm not sure why
they aren't there.
Adding them, running those lib commands, allowed me to link with no
errors or warnings.
Maybe I need to do some research on readline... this seems more
complicated than I expected.
Does no one else use readline on Windows? Is the Gnuwin32 readline a
fraud? I just don't know.
> -----Original Message-----
> From: Chuck McDevitt
> Sent: Monday, September 24, 2007 2:17 PM
> To: Magnus Hagander
> Cc: pgsql-hackers@postgresql.org
> Subject: RE: [HACKERS] Suggestion for MSVC build
>
> The right lib files to link readline are the .a ones...
>
> Like this:
>
> if ($solution->{options}->{readline})
> {
> $psql->AddIncludeDir($solution->{options}->{readline} .
> '\include');
> $psql->AddLibrary($solution->{options}->{readline} .
> '\lib\libreadline.dll.a');
> $psql->AddLibrary($solution->{options}->{readline} .
> '\lib\libhistory.dll.a');
> }
>
\
The .def files can be generated from cygwin or mingw's dlltool command: erase readline.def erase history.def dlltool --export-all-symbols -z readline.def libreadline.a dlltool --export-all-symbols -z history.def libhistory.a lib /machine:i386 /def:readline.def lib /machine:i386 /def:history.def (note: dlltool won't overwrite a def file if it exists). But why would this be necessary? It looks like the readline distribution is broken. > -----Original Message----- > From: Chuck McDevitt > Sent: Monday, September 24, 2007 11:59 PM > To: 'Magnus Hagander' > Cc: 'pgsql-hackers@postgresql.org' > Subject: RE: [HACKERS] Suggestion for MSVC build > > Actually, the more I look at it, I realize it was correct before > > We want to link against readline.lib and history.lib, but the ones in > the GnuWin32 distribution are broken. > The .lib files are made from the .def files, which are supposed to list > the exports, but don't. > > They can be made from commands like this: > > lib /machine:i386 /def:readline.def > lib /machine:i386 /def:history.def > > But that only works if the .def files list the routines you want > exported. > > It's easy enough to add the few we use by hand, but I'm not sure why > they aren't there. > Adding them, running those lib commands, allowed me to link with no > errors or warnings. > > Maybe I need to do some research on readline... this seems more > complicated than I expected. > Does no one else use readline on Windows? Is the Gnuwin32 readline a > fraud? I just don't know. >
Chuck McDevitt wrote: > Maybe I need to do some research on readline... this seems more > complicated than I expected. > Does no one else use readline on Windows? Is the Gnuwin32 readline a > fraud? I just don't know. readline has never worked well on Windows which is why we don't use it with the official builds. Even if you can get it to build, it'll only work in US locales iirc. From what you've posted of your experience, it doesn't sound like things have improved. The other option is libedit, but last I tried that didn't even build on Windows. That was some time ago though. Regards, Dave
On Mon, Sep 24, 2007 at 01:33:33PM -0400, Chuck McDevitt wrote: > Sorry, completion_matches hasn't existed in readline for a long time. > > You need to define: > > #define HAVE_RL_COMPLETION_APPEND_CHARACTER 1 > #define HAVE_RL_COMPLETION_MATCHES 1 > #define HAVE_RL_FILENAME_COMPLETION_FUNCTION 1 > > Just like we do on Linux. That wasn't in your orginal suggestion :-) Adding those it certainly works fine. (back to the lib issue, but that's a different thing) //Magnus
On Tue, Sep 25, 2007 at 02:58:54AM -0400, Chuck McDevitt wrote: > Actually, the more I look at it, I realize it was correct before > > We want to link against readline.lib and history.lib, but the ones in > the GnuWin32 distribution are broken. > The .lib files are made from the .def files, which are supposed to list > the exports, but don't. > > They can be made from commands like this: > > lib /machine:i386 /def:readline.def > lib /machine:i386 /def:history.def > > But that only works if the .def files list the routines you want > exported. > > It's easy enough to add the few we use by hand, but I'm not sure why > they aren't there. > Adding them, running those lib commands, allowed me to link with no > errors or warnings. > > Maybe I need to do some research on readline... this seems more > complicated than I expected. > Does no one else use readline on Windows? Is the Gnuwin32 readline a > fraud? I just don't know. The libs for MSVC are certainly broken. I've filed a bug with the gnuwin32 project, though I'm unsure if they'll fix it (the other bug filed against readilne has been open since march 2006 with no comment). (http://sourceforge.net/tracker/index.php?func=detail&aid=1801880&group_id=23617&atid=379173) Can you check if your manually linked version works in non-US locales? If you can't check, can you email me (offlist) with the binary (and the DLLs) and I can run a test here. If they *have* fixed the issue so it works in non-US locales, it's certainly worth expending some time making it work... //Magnus
Magnus Hagander wrote: > Can you check if your manually linked version works in non-US locales? If > you can't check, can you email me (offlist) with the binary (and the DLLs) > and I can run a test here. If they *have* fixed the issue so it works in > non-US locales, it's certainly worth expending some time making it work... > > > Many of us would like to see libedit ported to Windows too ;-) Meanwhile, as I observed to Magnus the other day, while the Cygwin server has issues that make it unsuitable for production use, the Cygwin psql client is still probably the best one for working on Windows. I know people who install Cygwin just so they can use its psql. (And yes, I'll repeat Magnus' caveat: don't ever put Cygwin in your Windows path). cheers andrew
On Tue, Sep 25, 2007 at 06:09:36AM -0400, Andrew Dunstan wrote: > > > Magnus Hagander wrote: > >Can you check if your manually linked version works in non-US locales? If > >you can't check, can you email me (offlist) with the binary (and the DLLs) > >and I can run a test here. If they *have* fixed the issue so it works in > >non-US locales, it's certainly worth expending some time making it work... > > > > > > > > Many of us would like to see libedit ported to Windows too ;-) Yeah, it's on my (insanely long) TODO to look at sometime :-) //Magnus
> > > > Many of us would like to see libedit ported to Windows too ;-) > > Yeah, it's on my (insanely long) TODO to look at sometime :-) > > //Magnus I've thought about working on a libedit port myself, but I don't see how that would help PostgreSQL unless the PostgreSQL community would be willing to include the libedit code into our source tree (pgsql/src/port/? ). Otherwise it would just be downloadable from some obscure place that most people won't find or trust.
Chuck McDevitt wrote: >>> Many of us would like to see libedit ported to Windows too ;-) >>> >> Yeah, it's on my (insanely long) TODO to look at sometime :-) >> >> //Magnus >> > > I've thought about working on a libedit port myself, but I don't see how > that would help PostgreSQL unless the PostgreSQL community would be > willing to include the libedit code into our source tree > (pgsql/src/port/? ). > > Otherwise it would just be downloadable from some obscure place that > most people won't find or trust. > It would mean that the distributed Windows binaries would be free of GPLed code. Most people don't actually build from source. I especially suspect that very few people build on Windows. cheers andrew
Chuck McDevitt wrote: > > > > > > Many of us would like to see libedit ported to Windows too ;-) > > > > Yeah, it's on my (insanely long) TODO to look at sometime :-) > > > > //Magnus > > I've thought about working on a libedit port myself, but I don't see how > that would help PostgreSQL unless the PostgreSQL community would be > willing to include the libedit code into our source tree > (pgsql/src/port/? ). > > Otherwise it would just be downloadable from some obscure place that > most people won't find or trust. Windows people only download the installer anyway, so that's not a problem. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Chuck McDevitt wrote: >>> Many of us would like to see libedit ported to Windows too ;-) >> Yeah, it's on my (insanely long) TODO to look at sometime :-) >> >> //Magnus > > I've thought about working on a libedit port myself, but I don't see how > that would help PostgreSQL unless the PostgreSQL community would be > willing to include the libedit code into our source tree > (pgsql/src/port/? ). > > Otherwise it would just be downloadable from some obscure place that > most people won't find or trust. Others have already pointed out the gain for users who download binary distributions. Heck, worst case, we can just stick a port on pgFoundry. So - let me know if you actively start looking at this, and if so let's cooperate. //Magnus