Обсуждение: tsearch2 patch for 7.4.1
Hi there, we have a patch for contrib/tsearch2 we'd like to commit for 7.4.1. Is it ok ? We added support for compound words using ispell dictionaries. It's rather important feature for agglutinative languages like german, norwegian (tested). This work was sponsored by ABC Startsiden (www.startsiden.no). Regards, Oleg _____________________________________________________________ Oleg Bartunov, sci.researcher, hostmaster of AstroNet, Sternberg Astronomical Institute, Moscow University (Russia) Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/ phone: +007(095)939-16-83, +007(095)939-23-83
Oleg Bartunov <oleg@sai.msu.su> writes:
> we have a patch for contrib/tsearch2 we'd like to commit for 7.4.1.
> Is it ok ?
> We added support for compound words using ispell dictionaries.
> It's rather important feature for agglutinative languages like
> german, norwegian (tested). This work was sponsored by ABC Startsiden
> (www.startsiden.no).
This strikes me as a feature addition, and therefore not appropriate for
the 7.4 branch. You should only commit bug fixes into stable branches,
not feature additions.
regards, tom lane
Tom Lane kirjutas N, 20.11.2003 kell 17:18: > Oleg Bartunov <oleg@sai.msu.su> writes: > > we have a patch for contrib/tsearch2 we'd like to commit for 7.4.1. > > Is it ok ? > > > We added support for compound words using ispell dictionaries. > > It's rather important feature for agglutinative languages like > > german, norwegian (tested). This work was sponsored by ABC Startsiden > > (www.startsiden.no). > > This strikes me as a feature addition, and therefore not appropriate for > the 7.4 branch. You should only commit bug fixes into stable branches, > not feature additions. Is this so even for contrib ? I seem to remember that there have been new feature popping up in contrib in stable branches earlier. But if the general direction is to stabilise contrib as well, what about committing it as a separate patch file contrib/tsearch2/patches/compond-words-patch.1 , so that these people (or german/norvegian linux distributors) who consider lack of support for compound words a bug can apply it themselves before building ? --------------- Hannu
No problem, dictionary with support of compounds will be avaliable as separate contrib module from our site till 7.5. Hannu Krosing wrote: > Tom Lane kirjutas N, 20.11.2003 kell 17:18: > >>Oleg Bartunov <oleg@sai.msu.su> writes: >> >>>we have a patch for contrib/tsearch2 we'd like to commit for 7.4.1. >>>Is it ok ? >> >>>We added support for compound words using ispell dictionaries. >>>It's rather important feature for agglutinative languages like >>>german, norwegian (tested). This work was sponsored by ABC Startsiden >>>(www.startsiden.no). >> >>This strikes me as a feature addition, and therefore not appropriate for >>the 7.4 branch. You should only commit bug fixes into stable branches, >>not feature additions. > > > Is this so even for contrib ? > > I seem to remember that there have been new feature popping up in > contrib in stable branches earlier. > > But if the general direction is to stabilise contrib as well, what about > committing it as a separate patch file > contrib/tsearch2/patches/compond-words-patch.1 , so that these people > (or german/norvegian linux distributors) who consider lack of support > for compound words a bug can apply it themselves before building ? > > --------------- > Hannu > > ---------------------------(end of broadcast)--------------------------- > TIP 8: explain analyze is your friend -- Teodor Sigaev E-mail: teodor@sigaev.ru
On Fri, 21 Nov 2003, Teodor Sigaev wrote: > No problem, dictionary with support of compounds will be avaliable as separate > contrib module from our site till 7.5. Hmm, I think better not to introduce another dictionary, which require additional efforts to configure tsearch2, but maintain whole module with new ispell dictionary builtin. Oleg > > > Hannu Krosing wrote: > > Tom Lane kirjutas N, 20.11.2003 kell 17:18: > > > >>Oleg Bartunov <oleg@sai.msu.su> writes: > >> > >>>we have a patch for contrib/tsearch2 we'd like to commit for 7.4.1. > >>>Is it ok ? > >> > >>>We added support for compound words using ispell dictionaries. > >>>It's rather important feature for agglutinative languages like > >>>german, norwegian (tested). This work was sponsored by ABC Startsiden > >>>(www.startsiden.no). > >> > >>This strikes me as a feature addition, and therefore not appropriate for > >>the 7.4 branch. You should only commit bug fixes into stable branches, > >>not feature additions. > > > > > > Is this so even for contrib ? > > > > I seem to remember that there have been new feature popping up in > > contrib in stable branches earlier. > > > > But if the general direction is to stabilise contrib as well, what about > > committing it as a separate patch file > > contrib/tsearch2/patches/compond-words-patch.1 , so that these people > > (or german/norvegian linux distributors) who consider lack of support > > for compound words a bug can apply it themselves before building ? > > > > --------------- > > Hannu > > > > ---------------------------(end of broadcast)--------------------------- > > TIP 8: explain analyze is your friend > > Regards, Oleg _____________________________________________________________ Oleg Bartunov, sci.researcher, hostmaster of AstroNet, Sternberg Astronomical Institute, Moscow University (Russia) Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/ phone: +007(095)939-16-83, +007(095)939-23-83
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Friday 21 November 2003 09:42, Oleg Bartunov wrote: > On Fri, 21 Nov 2003, Teodor Sigaev wrote: > > No problem, dictionary with support of compounds will be avaliable as > > separate contrib module from our site till 7.5. > > Hmm, I think better not to introduce another dictionary, which require > additional efforts to configure tsearch2, but maintain whole module > with new ispell dictionary builtin. > > Oleg I would very much like to use this new feature, and understand if it cannot be included in tsearch2 until 7.5. The easiest way for me as a user would be if, like Oleg suggests, it would be maintained as a whole module with ispell dictionary built in and was available fro download from the tsearch2-web-site. This should be mentioned in future (pg-7.4.x)READMEs. - -- Andreas Joseph Krogh <andreak@officenet.no> Managing Director, Senior Software Developer OfficeNet AS - - Writing software is more fun than working. gpg public_key: http://dev.officenet.no/~andreak/public_key.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQE/vdIvUopImDh2gfQRAnLnAJ9uUIH1TNLms6kuKC7ptNgOHCbGlQCffzU7 1sNuWfL1PWsqbJ0xIfxo8VA= =lRte -----END PGP SIGNATURE-----
On Fri, 21 Nov 2003, Andreas Joseph Krogh wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Friday 21 November 2003 09:42, Oleg Bartunov wrote: > > On Fri, 21 Nov 2003, Teodor Sigaev wrote: > > > No problem, dictionary with support of compounds will be avaliable as > > > separate contrib module from our site till 7.5. > > > > Hmm, I think better not to introduce another dictionary, which require > > additional efforts to configure tsearch2, but maintain whole module > > with new ispell dictionary builtin. > > > > Oleg > > I would very much like to use this new feature, and understand if it cannot be > included in tsearch2 until 7.5. The easiest way for me as a user would be if, > like Oleg suggests, it would be maintained as a whole module with ispell > dictionary built in and was available fro download from the > tsearch2-web-site. This should be mentioned in future (pg-7.4.x)READMEs. > ok, we decided to maintain patch to tsearch2 module on our web site. This would require a little efforts to compile but measy to maintain. Oleg > - -- > Andreas Joseph Krogh <andreak@officenet.no> > Managing Director, Senior Software Developer > OfficeNet AS > > - - Writing software is more fun than working. > > gpg public_key: http://dev.officenet.no/~andreak/public_key.asc > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.2.2 (GNU/Linux) > > iD8DBQE/vdIvUopImDh2gfQRAnLnAJ9uUIH1TNLms6kuKC7ptNgOHCbGlQCffzU7 > 1sNuWfL1PWsqbJ0xIfxo8VA= > =lRte > -----END PGP SIGNATURE----- > Regards, Oleg _____________________________________________________________ Oleg Bartunov, sci.researcher, hostmaster of AstroNet, Sternberg Astronomical Institute, Moscow University (Russia) Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/ phone: +007(095)939-16-83, +007(095)939-23-83