Обсуждение: AW: [HACKERS] PostgreSQL v6.4 BETA2...

The problem is probably that the functions incorrectly return text *
but use it like char *. text * is a varlena

e.g. text *inet_netmask in inet.c
    eighter must be char *inet_netmask or correctly use macros VARDATA and VARSIZE

Andreas

----------
Von:     D'Arcy J.M. Cain[SMTP:darcy@druid.net]
Gesendet:     Donnerstag, 15. Oktober 1998 13:54
An:     Marc G. Fournier
Cc:     pgsql-hackers@postgreSQL.org
Betreff:     Re: [HACKERS] PostgreSQL v6.4 BETA2...

Thus spake Marc G. Fournier
> With this BETA, the source code is frozen...there is *absolutely* no
> changes to be made except that which is required to fix a bug that
> pertains to the building and/or running on a particular platform, or to
> fix a crucial bug.

What about the inet stuff.  I'm just waiting for Paul's inet_cidr*
functions to test and submit the final stuff.  As it stand it will
crash the backend if you use it.  I guess that makes it a bug fix,
right?

I'll submit the builtins.h changes in the meantime.  Perhaps I can
cobble up my own version of the inet_cidr* functions at least to
be able to test my functions.

--
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 424 2871     (DoD#0082)    (eNTP)   |  what's for dinner.

Thus spake Andreas Zeugswetter
> The problem is probably that the functions incorrectly return text *
> but use it like char *. text * is a varlena

Yes, Bruce explained the change but I don't want to submit patches now
until the other functions have been added and I can test the module.

--
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 424 2871     (DoD#0082)    (eNTP)   |  what's for dinner.

> The problem is probably that the functions incorrectly return text *
> but use it like char *. text * is a varlena
>
> e.g. text *inet_netmask in inet.c
>     eighter must be char *inet_netmask or correctly use macros VARDATA and VARSIZE

No, they are missing sections as we wait for additional inet functions.


--
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026