Обсуждение: startup message -> StartupMessage

Поиск
Список
Период
Сортировка

startup message -> StartupMessage

От
Dmitry Igrishin
Дата:
Hi,

At https://www.postgresql.org/docs/9.6/static/protocol-flow.html
The StartupMessage instead of "startup message" may looks better for
the reader (at least for me).

--
// Dmitry.


Re: startup message -> StartupMessage

От
Bruce Momjian
Дата:
On Thu, Jun  9, 2016 at 03:38:40PM +0300, Dmitry Igrishin wrote:
> Hi,
>
> At https://www.postgresql.org/docs/9.6/static/protocol-flow.html
> The StartupMessage instead of "startup message" may looks better for
> the reader (at least for me).

Uh, where exactly?  Here?

    To begin a session, a frontend opens a connection to the server and
    sends a startup message.

In that case, it is highlighting it is a startup message, not the exact
message identifier.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+                     Ancient Roman grave inscription +


Re: startup message -> StartupMessage

От
Dmitry Igrishin
Дата:
2016-06-23 1:53 GMT+03:00 Bruce Momjian <bruce@momjian.us>:
> On Thu, Jun  9, 2016 at 03:38:40PM +0300, Dmitry Igrishin wrote:
>> Hi,
>>
>> At https://www.postgresql.org/docs/9.6/static/protocol-flow.html
>> The StartupMessage instead of "startup message" may looks better for
>> the reader (at least for me).
>
> Uh, where exactly?  Here?
I suggest everywhere on this page.
>
>         To begin a session, a frontend opens a connection to the server and
>         sends a startup message.
>
> In that case, it is highlighting it is a startup message, not the exact
> message identifier.
Yes, but see the next sentence: "This message includes the names of
the user and of the database the user wants to connect to; it also
identifies the particular protocol version to be used." So, it's about
the StartupMessage exactly.


Re: startup message -> StartupMessage

От
Bruce Momjian
Дата:
On Thu, Jun 23, 2016 at 07:47:10AM +0300, Dmitry Igrishin wrote:
> 2016-06-23 1:53 GMT+03:00 Bruce Momjian <bruce@momjian.us>:
> > On Thu, Jun  9, 2016 at 03:38:40PM +0300, Dmitry Igrishin wrote:
> >> Hi,
> >>
> >> At https://www.postgresql.org/docs/9.6/static/protocol-flow.html
> >> The StartupMessage instead of "startup message" may looks better for
> >> the reader (at least for me).
> >
> > Uh, where exactly?  Here?
> I suggest everywhere on this page.
> >
> >         To begin a session, a frontend opens a connection to the server and
> >         sends a startup message.
> >
> > In that case, it is highlighting it is a startup message, not the exact
> > message identifier.
> Yes, but see the next sentence: "This message includes the names of
> the user and of the database the user wants to connect to; it also
> identifies the particular protocol version to be used." So, it's about
> the StartupMessage exactly.

OK, how is this attached doc patch?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+                     Ancient Roman grave inscription +

Вложения

Re: startup message -> StartupMessage

От
Tom Lane
Дата:
Bruce Momjian <bruce@momjian.us> writes:
> On Thu, Jun 23, 2016 at 07:47:10AM +0300, Dmitry Igrishin wrote:
>> Yes, but see the next sentence: "This message includes the names of
>> the user and of the database the user wants to connect to; it also
>> identifies the particular protocol version to be used." So, it's about
>> the StartupMessage exactly.

> OK, how is this attached doc patch?

I do not think these are improvements.  This is introductory text,
not some kind of formal-language specification.

            regards, tom lane


Re: startup message -> StartupMessage

От
Dmitry Igrishin
Дата:
2016-06-23 16:38 GMT+03:00 Tom Lane <tgl@sss.pgh.pa.us>:
> Bruce Momjian <bruce@momjian.us> writes:
>> On Thu, Jun 23, 2016 at 07:47:10AM +0300, Dmitry Igrishin wrote:
>>> Yes, but see the next sentence: "This message includes the names of
>>> the user and of the database the user wants to connect to; it also
>>> identifies the particular protocol version to be used." So, it's about
>>> the StartupMessage exactly.
>
>> OK, how is this attached doc patch?
>
> I do not think these are improvements.  This is introductory text,
> not some kind of formal-language specification.
I can agree with this asserting when the text points to some abstract
message, like "The server then sends an appropriate authentication
request message" (because there are several kinds of authentication
messages). But for the concrete messages, there are consistency like
"The frontend must now send a PasswordMessage containing the
password", or "in the normal case the backend will send some
ParameterStatus messages", except the "During this phase the backend
will attempt to apply any additional run-time parameter settings that
were given in the startup message."

--
// Dmitry.