Обсуждение: pgsql: Split hash.h â hash_xlog.h
Split hash.h → hash_xlog.h Since the hash AM is going to be revamped to have WAL, this is a good opportunity to clean up the include file a little bit to avoid including a lot of extra stuff in the future. Author: Amit Kapila Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/8e1e3f958fb3749fe01e9f2473f4554859c685a8 Modified Files -------------- src/backend/access/hash/hash.c | 1 + src/backend/access/rmgrdesc/hashdesc.c | 2 +- src/backend/access/transam/rmgr.c | 2 +- src/bin/pg_xlogdump/rmgrdesc.c | 2 +- src/include/access/hash.h | 6 ------ src/include/access/hash_xlog.h | 25 +++++++++++++++++++++++++ 6 files changed, 29 insertions(+), 9 deletions(-)
On Tue, Aug 30, 2016 at 3:31 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > Split hash.h → hash_xlog.h I hope we're not going to make a regular habit of using Unicode glyphs in our commit messages.... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Robert Haas wrote: > On Tue, Aug 30, 2016 at 3:31 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > > Split hash.h → hash_xlog.h > > I hope we're not going to make a regular habit of using Unicode glyphs > in our commit messages.... Well, why not? We're already using diacritics in author names and such. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Tue, Aug 30, 2016 at 9:03 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > Robert Haas wrote: >> On Tue, Aug 30, 2016 at 3:31 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: >> > Split hash.h → hash_xlog.h >> >> I hope we're not going to make a regular habit of using Unicode glyphs >> in our commit messages.... > > Well, why not? We're already using diacritics in author names and such. I don't mind those, although I sometimes have difficulty typing them in properly - I often have to cut and paste from somewhere to get them to come out right. But: 1. I'm not sure that we want to deeply depend on everybody having perfect Unicode rendering in every tool anybody uses to look at the commit log. 2. I think that it's better to use words rather than pictures to explain things. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company