pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
От:
Simon Riggs <simon@2ndQuadrant.com>
Дата:
Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. Locks on inheritance parent remain at lower level, as they were before. Remove entry from 9.1 release notes. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/2c3d9db56d5d49bdc777b174982251c01348e3d8 Modified Files -------------- doc/src/sgml/release-9.1.sgml | 17 +---------------- src/backend/commands/tablecmds.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 16 deletions(-)
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
От:
Simon Riggs <simon@2ndQuadrant.com>
Дата:
On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs wrote: > Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. > Locks on inheritance parent remain at lower level, as they were before. > Remove entry from 9.1 release notes. This commit caused pgbuildfarm failures on 15 machines this morning. Later commit fixes this, I forgot that the lock level is specifically mentioned in regression test results. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
От:
Robert Haas <robertmhaas@gmail.com>
Дата:
On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs wrote: > On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs wrote: >> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. >> Locks on inheritance parent remain at lower level, as they were before. >> Remove entry from 9.1 release notes. > > This commit caused pgbuildfarm failures on 15 machines this morning. > Later commit fixes this, I forgot that the lock level is specifically > mentioned in regression test results. I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite(). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
От:
Simon Riggs <simon@2ndQuadrant.com>
Дата:
On Tue, Jul 5, 2011 at 2:46 PM, Robert Haas wrote: > On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs wrote: >> On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs wrote: >>> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. >>> Locks on inheritance parent remain at lower level, as they were before. >>> Remove entry from 9.1 release notes. >> >> This commit caused pgbuildfarm failures on 15 machines this morning. >> Later commit fixes this, I forgot that the lock level is specifically >> mentioned in regression test results. > > I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite(). Thanks. Will address. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
Robert Haas writes: > On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs wrote: >>> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. >>> Locks on inheritance parent remain at lower level, as they were before. >>> Remove entry from 9.1 release notes. > I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite(). I took care of this. regards, tom lane
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case
От:
Simon Riggs <simon@2ndQuadrant.com>
Дата:
On Thu, Jul 7, 2011 at 6:17 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs wrote: >>>> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. >>>> Locks on inheritance parent remain at lower level, as they were before. >>>> Remove entry from 9.1 release notes. > >> I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite(). > > I took care of this. Thanks. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services