Обсуждение: BUG #12770: Syntax error in a header file for sparcv8 elif errors compiling

The following bug has been logged on the website:

Bug reference:      12770
Logged by:          Rob Rowan
Email address:      rob.rowan@ngc.com
PostgreSQL version: 9.4.1
Operating system:   SunOS 5.10 Generic_141444-09 sun4u sparc SUNW
Description:

In src/include/storage/s_lock.h
Line 447
I believe the line that currently says:
elif  __sparcv8
Should be:
elif  defined(__sparcv8)

It compiled fine after I made that change.
If you have any questions, feel free to email me.

Hi,

On 2015-02-13 19:45:18 +0000, rob.rowan@ngc.com wrote:
> The following bug has been logged on the website:
>
> Bug reference:      12770
> Logged by:          Rob Rowan
> Email address:      rob.rowan@ngc.com
> PostgreSQL version: 9.4.1
> Operating system:   SunOS 5.10 Generic_141444-09 sun4u sparc SUNW
> Description:
>
> In src/include/storage/s_lock.h
> Line 447
> I believe the line that currently says:
> elif  __sparcv8
> Should be:
> elif  defined(__sparcv8)
>
> It compiled fine after I made that change.
> If you have any questions, feel free to email me.

Thanks for the report! Will fix.

Any chance you could contribute a buildfarm animal
(wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto) for sparcv8? It's
hard to keep supporting platforms without getting feedback during
development.


Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

On 02/13/2015 11:54 PM, Andres Freund wrote:
> Hi,
>
> On 2015-02-13 19:45:18 +0000, rob.rowan@ngc.com wrote:
>> The following bug has been logged on the website:
>>
>> Bug reference:      12770
>> Logged by:          Rob Rowan
>> Email address:      rob.rowan@ngc.com
>> PostgreSQL version: 9.4.1
>> Operating system:   SunOS 5.10 Generic_141444-09 sun4u sparc SUNW
>> Description:
>>
>> In src/include/storage/s_lock.h
>> Line 447
>> I believe the line that currently says:
>> elif  __sparcv8
>> Should be:
>> elif  defined(__sparcv8)
>>
>> It compiled fine after I made that change.
>> If you have any questions, feel free to email me.
>
> Thanks for the report! Will fix.

Ah, I just committed this. Sorry to joggle your elbow.

> Any chance you could contribute a buildfarm animal
> (wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto) for sparcv8? It's
> hard to keep supporting platforms without getting feedback during
> development.

Yeah, that would be good...

- Heikki