Обсуждение: restore bug of pgadminIII 1.20.0

Поиск
Список
Период
Сортировка

restore bug of pgadminIII 1.20.0

От
YuanyuanLiu
Дата:
Hi, I found a bug of restore of pgadminIII v1.20.0 , which I installed by
postgresql-9.4 Graphical installer for windows 32bit).

This is my test example: I tried use pgadminIII to restore table A1 in
schema publicA in database  Vvv1.
then it failed and I got the message:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table \"A1\" --schem
a \"publicA\" --verbose "C:\Users\Yuanyuan\Desktop\1"
....

I found the table and schema name format is wrong, the right way is like the
follwing. and success to restore my table by execute commands like the
following:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table "A1" --schema
"publicA" --verbose "C:\Users\Yuanyuan\Desktop\1"

I don't know whether anyone has fixed this problem, so I write this to you!
please have a look!
Thanks and regards!

Holiday Liu





--
View this message in context: http://postgresql.nabble.com/restore-bug-of-pgadminIII-1-20-0-tp5879508.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.com.



Re: restore bug of pgadminIII 1.20.0

От
Dave Page
Дата:
Neel, can you look at this please? 

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 30 Dec 2015, at 08:14, YuanyuanLiu <liuyuanyuangogo@gmail.com> wrote:

Hi, I found a bug of restore of pgadminIII v1.20.0 , which I installed by
postgresql-9.4 Graphical installer for windows 32bit).

This is my test example: I tried use pgadminIII to restore table A1 in
schema publicA in database  Vvv1.
then it failed and I got the message:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port
5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table \"A1\" --schem
a \"publicA\" --verbose "C:\Users\Yuanyuan\Desktop\1"
....

I found the table and schema name format is wrong, the right way is like the
follwing. and success to restore my table by execute commands like the
following:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port
5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table "A1" --schema
"publicA" --verbose "C:\Users\Yuanyuan\Desktop\1"

I don't know whether anyone has fixed this problem, so I write this to you!
please have a look!
Thanks and regards!

Holiday Liu






--
View this message in context: http://postgresql.nabble.com/restore-bug-of-pgadminIII-1-20-0-tp5879508.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.com.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

Re: restore bug of pgadminIII 1.20.0

От
Neel Patel
Дата:
Hi Dave,

Sure. I will look into this issue and share the analysis/fix.

Thanks,
Neel Patel

On Wed, Dec 30, 2015 at 4:33 PM, Dave Page <dpage@pgadmin.org> wrote:
Neel, can you look at this please? 

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 30 Dec 2015, at 08:14, YuanyuanLiu <liuyuanyuangogo@gmail.com> wrote:

Hi, I found a bug of restore of pgadminIII v1.20.0 , which I installed by
postgresql-9.4 Graphical installer for windows 32bit).

This is my test example: I tried use pgadminIII to restore table A1 in
schema publicA in database  Vvv1.
then it failed and I got the message:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port
5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table \"A1\" --schem
a \"publicA\" --verbose "C:\Users\Yuanyuan\Desktop\1"
....

I found the table and schema name format is wrong, the right way is like the
follwing. and success to restore my table by execute commands like the
following:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port
5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table "A1" --schema
"publicA" --verbose "C:\Users\Yuanyuan\Desktop\1"

I don't know whether anyone has fixed this problem, so I write this to you!
please have a look!
Thanks and regards!

Holiday Liu






--
View this message in context: http://postgresql.nabble.com/restore-bug-of-pgadminIII-1-20-0-tp5879508.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.com.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

Re: restore bug of pgadminIII 1.20.0

От
Neel Patel
Дата:
Hi,

Please find the attached patch file with the fix.
 - Reformatted the input string for the "pg_restore" command line options.

Let me know for any comments.

Thanks,
Neel Patel

On Wed, Dec 30, 2015 at 4:37 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Sure. I will look into this issue and share the analysis/fix.

Thanks,
Neel Patel

On Wed, Dec 30, 2015 at 4:33 PM, Dave Page <dpage@pgadmin.org> wrote:
Neel, can you look at this please? 

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 30 Dec 2015, at 08:14, YuanyuanLiu <liuyuanyuangogo@gmail.com> wrote:

Hi, I found a bug of restore of pgadminIII v1.20.0 , which I installed by
postgresql-9.4 Graphical installer for windows 32bit).

This is my test example: I tried use pgadminIII to restore table A1 in
schema publicA in database  Vvv1.
then it failed and I got the message:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port
5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table \"A1\" --schem
a \"publicA\" --verbose "C:\Users\Yuanyuan\Desktop\1"
....

I found the table and schema name format is wrong, the right way is like the
follwing. and success to restore my table by execute commands like the
following:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port
5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table "A1" --schema
"publicA" --verbose "C:\Users\Yuanyuan\Desktop\1"

I don't know whether anyone has fixed this problem, so I write this to you!
please have a look!
Thanks and regards!

Holiday Liu






--
View this message in context: http://postgresql.nabble.com/restore-bug-of-pgadminIII-1-20-0-tp5879508.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.com.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support


Вложения

Re: restore bug of pgadminIII 1.20.0

От
Dave Page
Дата:
Ashesh - can you review/commit please?

Thanks.

On Wed, Jan 6, 2016 at 9:16 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch file with the fix.
>  - Reformatted the input string for the "pg_restore" command line options.
>
> Let me know for any comments.
>
> Thanks,
> Neel Patel
>
> On Wed, Dec 30, 2015 at 4:37 PM, Neel Patel <neel.patel@enterprisedb.com>
> wrote:
>>
>> Hi Dave,
>>
>> Sure. I will look into this issue and share the analysis/fix.
>>
>> Thanks,
>> Neel Patel
>>
>> On Wed, Dec 30, 2015 at 4:33 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Neel, can you look at this please?
>>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK:http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On 30 Dec 2015, at 08:14, YuanyuanLiu <liuyuanyuangogo@gmail.com> wrote:
>>>
>>> Hi, I found a bug of restore of pgadminIII v1.20.0 , which I installed by
>>> postgresql-9.4 Graphical installer for windows 32bit).
>>>
>>> This is my test example: I tried use pgadminIII to restore table A1 in
>>> schema publicA in database  Vvv1.
>>> then it failed and I got the message:
>>> D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
>>> --port
>>> 5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
>>> --table \"A1\" --schem
>>> a \"publicA\" --verbose "C:\Users\Yuanyuan\Desktop\1"
>>> ....
>>>
>>> I found the table and schema name format is wrong, the right way is like
>>> the
>>> follwing. and success to restore my table by execute commands like the
>>> following:
>>> D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
>>> --port
>>> 5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
>>> --table "A1" --schema
>>> "publicA" --verbose "C:\Users\Yuanyuan\Desktop\1"
>>>
>>> I don't know whether anyone has fixed this problem, so I write this to
>>> you!
>>> please have a look!
>>> Thanks and regards!
>>>
>>> Holiday Liu
>>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>> http://postgresql.nabble.com/restore-bug-of-pgadminIII-1-20-0-tp5879508.html
>>> Sent from the PostgreSQL - pgadmin support mailing list archive at
>>> Nabble.com.
>>>
>>>
>>> --
>>> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-support
>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Re: restore bug of pgadminIII 1.20.0

От
Ashesh Vashi
Дата:
Hi Neel,

On Wed, Jan 6, 2016 at 2:46 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find the attached patch file with the fix.
 - Reformatted the input string for the "pg_restore" command line options.
We're using 'commandLineCleanOption' a quite a lot place with second argument as true.

Do you think - they do work well there?
i.e.
frmBackup class
In the same function for function object.

Eyeball review suggests - it should not.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


Let me know for any comments.

Thanks,
Neel Patel

On Wed, Dec 30, 2015 at 4:37 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Sure. I will look into this issue and share the analysis/fix.

Thanks,
Neel Patel

On Wed, Dec 30, 2015 at 4:33 PM, Dave Page <dpage@pgadmin.org> wrote:
Neel, can you look at this please? 

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 30 Dec 2015, at 08:14, YuanyuanLiu <liuyuanyuangogo@gmail.com> wrote:

Hi, I found a bug of restore of pgadminIII v1.20.0 , which I installed by
postgresql-9.4 Graphical installer for windows 32bit).

This is my test example: I tried use pgadminIII to restore table A1 in
schema publicA in database  Vvv1.
then it failed and I got the message:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port
5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table \"A1\" --schem
a \"publicA\" --verbose "C:\Users\Yuanyuan\Desktop\1"
....

I found the table and schema name format is wrong, the right way is like the
follwing. and success to restore my table by execute commands like the
following:
D:\Program Files (x86)\PostgreSQL\9.4\bin>pg_restore.exe --host localhost
--port
5433 --username "postgres" --dbname "Vvv1"   --no-password --data-only
--table "A1" --schema
"publicA" --verbose "C:\Users\Yuanyuan\Desktop\1"

I don't know whether anyone has fixed this problem, so I write this to you!
please have a look!
Thanks and regards!

Holiday Liu






--
View this message in context: http://postgresql.nabble.com/restore-bug-of-pgadminIII-1-20-0-tp5879508.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.com.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support




--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support