Обсуждение: 1.16.1: many operations cause display tree to collapse

<font face="arial" size="2"><p style="margin:0;padding:0;">Hi - I am using pgadmin 1.16.1 on Windows 7 against PG 9.1.
WhenI add a new table, add a column, or alter a column, the Object browser tree display collapses as if I did a refresh
highup in the object tree. I have to open up several levels in the tree again to get to the table to do further work on
it.This is tedious.<p style="margin:0;padding:0;"> <p style="margin:0;padding:0;">I installed pgadmin 1.14.3
side-by-sideand do not see this problem. New tables or ALTER-TABLE style operations do not collapse the tree.<p
style="margin:0;padding:0;"> <pstyle="margin:0;padding:0;">Is this something new and necessary, or is it a bug?<p
style="margin:0;padding:0;"> <pstyle="margin:0;padding:0;">Thanks a lot,<p style="margin:0;padding:0;">Dan</font> 

On Mon, Jan 14, 2013 at 7:40 PM, Dan Halbert <halbert@halwitz.org> wrote:
> Hi - I am using pgadmin 1.16.1 on Windows 7 against PG 9.1. When I add a new
> table, add a column, or alter a column, the Object browser tree display
> collapses as if I did a refresh high up in the object tree. I have to open
> up several levels in the tree again to get to the table to do further work
> on it. This is tedious.
>
>
>
> I installed pgadmin 1.14.3 side-by-side and do not see this problem. New
> tables or ALTER-TABLE style operations do not collapse the tree.

I can't reproduce this on Mac (the logic is the same on all platforms)
- but what do you have File -> Preferences -> Browser -> UI
Miscellaneous -> Refresh on click set to?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

>On Mon, Jan 14, 2013 at 7:40 PM, Dan Halbert <halbert@halwitz.org> wrote:
>>  Hi - I am using pgadmin 1.16.1 on Windows 7 against PG 9.1. When I add a new
>>  table, add a column, or alter a column, the Object browser tree display
>>  collapses as if I did a refresh high up in the object tree. I have to open
>>  up several levels in the tree again to get to the table to do further work
>>  on it. This is tedious.
>>
>>
>>
>>  I installed pgadmin 1.14.3 side-by-side and do not see this problem. New
>>  tables or ALTER-TABLE style operations do not collapse the tree.
>
>I can't reproduce this on Mac (the logic is the same on all platforms)
>- but what do you have File -> Preferences -> Browser -> UI
>Miscellaneous -> Refresh on click set to?

I have the same issue on a Mac. It also happens when modifying 
constraint and index names.
Mac OS X 10.6.8
pgAdmin3 1.16.1
UI Miscellaneous -> Refresh on click -> any setting

<div dir="ltr">Greetings !<br /> <br />It is observed that there are very frequent errors related to below:<br />"could
notreceive data from client: Connection reset by peer.  Unexpected EOF on client connection."  These are seen heavily
inthe pg_log files.  some of them are seen as fatal errors and the database gets shutdown after the above messages. 
Howdo I get rid of these messages.<br /> <br />Is this related to postgres configuration issue or the client/Java
programwhich is not doing proper handshake with postgres database and dropping connections.  Please advise.<br /> <br
/> <br/>Thanks and Regards<br />Radha<br /> <br /> <br /></div> 

OK, I finally managed to recreate this. It doesn't do it for me when
adding columns as described, but does if I rename one. I'll have a
poke around and figure out what's going on.

On Fri, Feb 1, 2013 at 7:25 AM, Gary Giumarra <ggiumarra@yahoo.com> wrote:
> Can't say for sure, but there was a bug in 1.16 that caused pgAdmin III to
> freeze up when performing such operations as renaming a table.  Version
> 1.16.1 fixed that problem, but now you get the tree collapse you describe.
> Perhaps the "quick and dirty fix" involved this behaviour?  I find it
> annoying as well, but not nearly as annoying as the freeze up!
>
>
>
>
> Gary Giumarra
>
> DealerBuilt-Lightyear Dealer Technologies, LLC.
>
>
> ________________________________
> From: Chris Bartlett <c.bartlett@paradise.net.nz>
> To: pgAdmin Support <pgadmin-support@postgresql.org>
> Cc: Dave Page <dpage@pgadmin.org>
> Sent: Thu, January 31, 2013 4:02:09 PM
> Subject: Re: [pgadmin-support] 1.16.1: many operations cause display tree to
> collapse
>
>>On Mon, Jan 14, 2013 at 7:40 PM, Dan Halbert <halbert@halwitz.org> wrote:
>>>  Hi - I am using pgadmin 1.16.1 on Windows 7 against PG 9.1. When I add a
>>> new
>>>  table, add a column, or alter a column, the Object browser tree display
>>>  collapses as if I did a refresh high up in the object tree. I have to
>>> open
>>>  up several levels in the tree again to get to the table to do further
>>> work
>>>  on it. This is tedious.
>>>
>>>
>>>
>>>  I installed pgadmin 1.14.3 side-by-side and do not see this problem. New
>>>  tables or ALTER-TABLE style operations do not collapse the tree.
>>
>>I can't reproduce this on Mac (the logic is the same on all platforms)
>>- but what do you have File -> Preferences -> Browser -> UI
>>Miscellaneous -> Refresh on click set to?
>
> I have the same issue on a Mac. It also happens when modifying
> constraint and index names.
> Mac OS X 10.6.8
> pgAdmin3 1.16.1
> UI Miscellaneous -> Refresh on click -> any setting
>
>
>
> --
> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-support



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Feb 4, 2013 at 3:54 PM, Dan Halbert <halbert@halwitz.org> wrote:
>
> On Monday, February 4, 2013 10:37am, "Dave Page" <dpage@pgadmin.org> said:
>
> > OK, I finally managed to recreate this. It doesn't do it for me when
> > adding columns as described, but does if I rename one. I'll have a
> > poke around and figure out what's going on.
>
> > >>I can't reproduce this on Mac (the logic is the same on all platforms)
> > >>- but what do you have File -> Preferences -> Browser -> UI
> > >>Miscellaneous -> Refresh on click set to?
> > >
> > > I have the same issue on a Mac. It also happens when modifying
> > > constraint and index names.
> > > Mac OS X 10.6.8
> > > pgAdmin3 1.16.1
> > > UI Miscellaneous -> Refresh on click -> any setting
>
>
>
> Sorry, I never saw this query from last month. For me, I have Refresh set to None.
> I think it's a bit weird you are not seeing this problem on adding columns, but two others of us are. Is there any
wayit could have to do with the server version? I am using 1.16.1 against PostgreSQL 9.1, running on Ubuntu 12.04,
updatedto the latest standard repo version there. 
> Dan


Apologies for not getting further with this - it hasn't been forgotten!

Akshay/Ashesh; as I mentioned in our meeting earlier today, I believe
I've isolated the cause of this to this patch:

http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=cb5dba55dc491107e4152bd80ec496294e449934

Specifically, I think the mainForm->Refresh(tblobj) call that's been
added to dlgProperty::ShowObject() is messing up the attempt to
re-open the tree to the original state during the existing refresh.
Can one or both of you investigate further please?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Is anyone paying attention to this?

On Sun, Apr 14, 2013 at 9:13 AM, Michael Shapiro <mshapiro51@gmail.com> wrote:

I can confirm this behavior as well.

On Sun, Apr 14, 2013 at 8:52 AM, Aren Cambre <aren@arencambre.com> wrote:

Just FYI, this bug is still present in 1.16.1 (Apr 2, 2013, rev: REL-1_16_1).

As for whether it happens when adding columns, my experience on Windows 7 is that the tree doesn't collapse when when I add columns or do other modifications through the table's Properties dialog. Otherwise, it happens whenever I complete a change that was initiated by right-clicking on any of the nodes below the table (Columns, Constraints, etc.).

Aren

On Mon, Feb 18, 2013 at 10:19 AM, Dave Page <dpage@pgadmin.org> wrote:

On Mon, Feb 4, 2013 at 3:54 PM, Dan Halbert <halbert@halwitz.org> wrote:
>
> On Monday, February 4, 2013 10:37am, "Dave Page" <dpage@pgadmin.org> said:
>
> > OK, I finally managed to recreate this. It doesn't do it for me when
> > adding columns as described, but does if I rename one. I'll have a
> > poke around and figure out what's going on.
>
> > >>I can't reproduce this on Mac (the logic is the same on all platforms)
> > >>- but what do you have File -> Preferences -> Browser -> UI
> > >>Miscellaneous -> Refresh on click set to?
> > >
> > > I have the same issue on a Mac. It also happens when modifying
> > > constraint and index names.
> > > Mac OS X 10.6.8
> > > pgAdmin3 1.16.1
> > > UI Miscellaneous -> Refresh on click -> any setting
>
>
>
> Sorry, I never saw this query from last month. For me, I have Refresh set to None.
> I think it's a bit weird you are not seeing this problem on adding columns, but two others of us are. Is there any way it could have to do with the server version? I am using 1.16.1 against PostgreSQL 9.1, running on Ubuntu 12.04, updated to the latest standard repo version there.
> Dan

Apologies for not getting further with this - it hasn't been forgotten!

Akshay/Ashesh; as I mentioned in our meeting earlier today, I believe
I've isolated the cause of this to this patch:

http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=cb5dba55dc491107e4152bd80ec496294e449934

Specifically, I think the mainForm->Refresh(tblobj) call that's been
added to dlgProperty::ShowObject() is messing up the attempt to
re-open the tree to the original state during the existing refresh.
Can one or both of you investigate further please?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

On Sat, May 11, 2013 at 2:56 AM, Aren Cambre <aren@arencambre.com> wrote:
> Thanks. I'll shut up now. :-)
>
> You guys really need a bug tracker.

We have one: http://code.pgadmin.org/trac/query

It's only used for triaged bugs that aren't being immediately worked on though.

> On Thu, May 9, 2013 at 1:02 AM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Yes.
>>
>>
>> On Thursday, May 9, 2013, Aren Cambre wrote:
>>>
>>> Is anyone paying attention to this?
>>>
>>> On Sun, Apr 14, 2013 at 9:13 AM, Michael Shapiro <mshapiro51@gmail.com>
>>> wrote:
>>>>
>>>> I can confirm this behavior as well.
>>>>
>>>> On Sun, Apr 14, 2013 at 8:52 AM, Aren Cambre <aren@arencambre.com>
>>>> wrote:
>>>>>
>>>>> Just FYI, this bug is still present in 1.16.1 (Apr 2, 2013, rev:
>>>>> REL-1_16_1).
>>>>>
>>>>> As for whether it happens when adding columns, my experience on Windows
>>>>> 7 is that the tree doesn't collapse when when I add columns or do other
>>>>> modifications through the table's Properties dialog. Otherwise, it happens
>>>>> whenever I complete a change that was initiated by right-clicking on any of
>>>>> the nodes below the table (Columns, Constraints, etc.).
>>>>>
>>>>> Aren
>>>>>
>>>>>
>>>>> On Mon, Feb 18, 2013 at 10:19 AM, Dave Page <dpage@pgadmin.org> wrote:
>>>>>>
>>>>>> On Mon, Feb 4, 2013 at 3:54 PM, Dan Halbert <halbert@halwitz.org>
>>>>>> wrote:
>>>>>> >
>>>>>> > On Monday, February 4, 2013 10:37am, "Dave Page" <dpage@pgadmin.org>
>>>>>> > said:
>>>>>> >
>>>>>> > > OK, I finally managed to recreate this. It doesn't do it for me
>>>>>> > > when
>>>>>> > > adding columns as described, but does if I rename one. I'll have a
>>>>>> > > poke around and figure out what's going on.
>>>>>> >
>>>>>> > > >>I can't reproduce this on Mac (the logic is the same on all
>>>>>> > > >> platforms)
>>>>>> > > >>- but what do you have File -> Preferences -> Browser -> UI
>>>>>> > > >>Miscellaneous -> Refresh on click set to?
>>>>>> > > >
>>>>>> > > > I have the same issue on a Mac. It also happens when modifying
>>>>>> > > > constraint and index names.
>>>>>> > > > Mac OS X 10.6.8
>>>>>> > > > pgAdmin3 1.16.1
>>>>>> > > > UI Miscellaneous -> Refresh on click -> any setting
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> > Sorry, I never saw this query from last month. For me, I have
>>>>>> > Refresh set to None.
>>>>>> > I think it's a bit weird you are not seeing this problem on adding
>>>>>> > columns, but two others of us are. Is there any way it could have to do with
>>>>>> > the server version? I am using 1.16.1 against PostgreSQL 9.1, running on
>>>>>> > Ubuntu 12.04, updated to the latest standard repo version there.
>>>>>> > Dan
>>>>>>
>>>>>>
>>>>>> Apologies for not getting further with this - it hasn't been
>>>>>> forgotten!
>>>>>>
>>>>>> Akshay/Ashesh; as I mentioned in our meeting earlier today, I believe
>>>>>> I've isolated the cause of this to this patch:
>>>>>>
>>>>>>
>>>>>> http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=cb5dba55dc491107e4152bd80ec496294e449934
>>>>>>
>>>>>> Specifically, I think the mainForm->Refresh(tblobj) call that's been
>>>>>> added to dlgProperty::ShowObject() is messing up the attempt to
>>>>>> re-open the tree to the original state during the existing refresh.
>>>>>> Can one or both of you investigate further please?
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
>>>>>> To make changes to your subscription:
>>>>>> http://www.postgresql.org/mailpref/pgadmin-support
>>>>>
>>>>>
>>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

OK, so I finally managed to track down the root cause of this bug -
specifically, it's this change:
http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=e97d351dcbc42a38f0054a81f37727d511087ffa

We're looking into the most appropriate way to fix it properly.

On Mon, May 13, 2013 at 8:43 AM, Dave Page <dpage@pgadmin.org> wrote:
> On Sat, May 11, 2013 at 2:56 AM, Aren Cambre <aren@arencambre.com> wrote:
>> Thanks. I'll shut up now. :-)
>>
>> You guys really need a bug tracker.
>
> We have one: http://code.pgadmin.org/trac/query
>
> It's only used for triaged bugs that aren't being immediately worked on though.
>
>> On Thu, May 9, 2013 at 1:02 AM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Yes.
>>>
>>>
>>> On Thursday, May 9, 2013, Aren Cambre wrote:
>>>>
>>>> Is anyone paying attention to this?
>>>>
>>>> On Sun, Apr 14, 2013 at 9:13 AM, Michael Shapiro <mshapiro51@gmail.com>
>>>> wrote:
>>>>>
>>>>> I can confirm this behavior as well.
>>>>>
>>>>> On Sun, Apr 14, 2013 at 8:52 AM, Aren Cambre <aren@arencambre.com>
>>>>> wrote:
>>>>>>
>>>>>> Just FYI, this bug is still present in 1.16.1 (Apr 2, 2013, rev:
>>>>>> REL-1_16_1).
>>>>>>
>>>>>> As for whether it happens when adding columns, my experience on Windows
>>>>>> 7 is that the tree doesn't collapse when when I add columns or do other
>>>>>> modifications through the table's Properties dialog. Otherwise, it happens
>>>>>> whenever I complete a change that was initiated by right-clicking on any of
>>>>>> the nodes below the table (Columns, Constraints, etc.).
>>>>>>
>>>>>> Aren
>>>>>>
>>>>>>
>>>>>> On Mon, Feb 18, 2013 at 10:19 AM, Dave Page <dpage@pgadmin.org> wrote:
>>>>>>>
>>>>>>> On Mon, Feb 4, 2013 at 3:54 PM, Dan Halbert <halbert@halwitz.org>
>>>>>>> wrote:
>>>>>>> >
>>>>>>> > On Monday, February 4, 2013 10:37am, "Dave Page" <dpage@pgadmin.org>
>>>>>>> > said:
>>>>>>> >
>>>>>>> > > OK, I finally managed to recreate this. It doesn't do it for me
>>>>>>> > > when
>>>>>>> > > adding columns as described, but does if I rename one. I'll have a
>>>>>>> > > poke around and figure out what's going on.
>>>>>>> >
>>>>>>> > > >>I can't reproduce this on Mac (the logic is the same on all
>>>>>>> > > >> platforms)
>>>>>>> > > >>- but what do you have File -> Preferences -> Browser -> UI
>>>>>>> > > >>Miscellaneous -> Refresh on click set to?
>>>>>>> > > >
>>>>>>> > > > I have the same issue on a Mac. It also happens when modifying
>>>>>>> > > > constraint and index names.
>>>>>>> > > > Mac OS X 10.6.8
>>>>>>> > > > pgAdmin3 1.16.1
>>>>>>> > > > UI Miscellaneous -> Refresh on click -> any setting
>>>>>>> >
>>>>>>> >
>>>>>>> >
>>>>>>> > Sorry, I never saw this query from last month. For me, I have
>>>>>>> > Refresh set to None.
>>>>>>> > I think it's a bit weird you are not seeing this problem on adding
>>>>>>> > columns, but two others of us are. Is there any way it could have to do with
>>>>>>> > the server version? I am using 1.16.1 against PostgreSQL 9.1, running on
>>>>>>> > Ubuntu 12.04, updated to the latest standard repo version there.
>>>>>>> > Dan
>>>>>>>
>>>>>>>
>>>>>>> Apologies for not getting further with this - it hasn't been
>>>>>>> forgotten!
>>>>>>>
>>>>>>> Akshay/Ashesh; as I mentioned in our meeting earlier today, I believe
>>>>>>> I've isolated the cause of this to this patch:
>>>>>>>
>>>>>>>
>>>>>>> http://git.postgresql.org/gitweb/?p=pgadmin3.git;a=commit;h=cb5dba55dc491107e4152bd80ec496294e449934
>>>>>>>
>>>>>>> Specifically, I think the mainForm->Refresh(tblobj) call that's been
>>>>>>> added to dlgProperty::ShowObject() is messing up the attempt to
>>>>>>> re-open the tree to the original state during the existing refresh.
>>>>>>> Can one or both of you investigate further please?
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
>>>>>>> To make changes to your subscription:
>>>>>>> http://www.postgresql.org/mailpref/pgadmin-support
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company