Обсуждение: pgAdmin III 1.10 beta - Server Status page

If the server connection drops while on the server status page, a popup is created every time the page refreshes.  

To reproduce, connect to a server an monitor it, then stop the server.  

On Fri, Mar 20, 2009 at 9:26 PM, Mike Blackwell <maiku41@sbcglobal.net> wrote:
>
> If the server connection drops while on the server status page, a popup is created every time the page refreshes.
>
> To reproduce, connect to a server an monitor it, then stop the server.

Any thoughts on the best way to handle this Guillaume? Perhaps just
stop the refresh timers as soon as a connection error occurs (and
display a message on the status bar or somewhere).


-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

Le samedi 21 mars 2009 à 14:25:32, Dave Page a écrit :
> On Fri, Mar 20, 2009 at 9:26 PM, Mike Blackwell <maiku41@sbcglobal.net>
wrote:
> > If the server connection drops while on the server status page, a popup
> > is created every time the page refreshes.
> >
> > To reproduce, connect to a server an monitor it, then stop the server.
>
> Any thoughts on the best way to handle this Guillaume? Perhaps just
> stop the refresh timers as soon as a connection error occurs (and
> display a message on the status bar or somewhere).
>

That's what I did in this patch. If it's OK for you, I'll commit it.


--
Guillaume.http://www.postgresqlfr.orghttp://dalibo.com

On Sat, Mar 21, 2009 at 3:56 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le samedi 21 mars 2009 à 14:25:32, Dave Page a écrit :
>> On Fri, Mar 20, 2009 at 9:26 PM, Mike Blackwell <maiku41@sbcglobal.net>
> wrote:
>> > If the server connection drops while on the server status page, a popup
>> > is created every time the page refreshes.
>> >
>> > To reproduce, connect to a server an monitor it, then stop the server.
>>
>> Any thoughts on the best way to handle this Guillaume? Perhaps just
>> stop the refresh timers as soon as a connection error occurs (and
>> display a message on the status bar or somewhere).
>>
>
> That's what I did in this patch. If it's OK for you, I'll commit it.

Looks OK to my eyeballs :-). I'd suggest using just one error message
though: _("Connection broken.")


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

Le lundi 23 mars 2009 à 09:47:20, Dave Page a écrit :
> On Sat, Mar 21, 2009 at 3:56 PM, Guillaume Lelarge
>
> <guillaume@lelarge.info> wrote:
> > Le samedi 21 mars 2009 à 14:25:32, Dave Page a écrit :
> >> On Fri, Mar 20, 2009 at 9:26 PM, Mike Blackwell <maiku41@sbcglobal.net>
> >
> > wrote:
> >> > If the server connection drops while on the server status page, a
> >> > popup is created every time the page refreshes.
> >> >
> >> > To reproduce, connect to a server an monitor it, then stop the server.
> >>
> >> Any thoughts on the best way to handle this Guillaume? Perhaps just
> >> stop the refresh timers as soon as a connection error occurs (and
> >> display a message on the status bar or somewhere).
> >
> > That's what I did in this patch. If it's OK for you, I'll commit it.
>
> Looks OK to my eyeballs :-). I'd suggest using just one error message
> though: _("Connection broken.")
>

Done, thanks.


--
Guillaume.http://www.postgresqlfr.orghttp://dalibo.com