Обсуждение: [pgAdmin4][debugger]: RM #1354 & RM #1323

Hi,

Please find attached patch file for the fix of RM #1354 and RM #1323.

RM 1354 - Debugging PL/pgSQL causes "Debugger: Error fetching variable information".

RM 1323 - Debugger: Continue execution error displayed if debug plpgsql function in Desktop Runtime Application.

Both the issue are related. Below are the issue description and solution.

Issue :- 

We are getting error of "fetching variable information" and "execution error" because as one query is already in state of execution and at the same time without getting its result we are sending another query to fetch the variable and stack information and due to that we are getting the error.

Solution:-

We should give enough time for execution query to finish its operation and then we should get the function debug information like variable info, stack info, breakpoint info etc.

Do review it and let us know for comments.

Thanks,

Neel Patel

<RM_1354_1323.patch>

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Hi

On Sun, Jun 19, 2016 at 5:50 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi Dave,
>
> make sense. We should ensure that operations happen sequentially.
> Please find attached patch file for the fix.

Hmm, using synchronous calls is not an option either. They're strongly
discouraged, and will throw warnings on some browsers.

Can we not just have the first callback initiate the next call and so on?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks, applied.

On Mon, Jun 20, 2016 at 10:06 AM, Neel Patel
<neel.patel@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find attached modified patch file. Do review it and let us know for
> comments.
>
> Thanks,
> Neel Patel
>
> On Mon, Jun 20, 2016 at 2:08 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Sun, Jun 19, 2016 at 5:50 PM, Neel Patel <neel.patel@enterprisedb.com>
>> wrote:
>> > Hi Dave,
>> >
>> > make sense. We should ensure that operations happen sequentially.
>> > Please find attached patch file for the fix.
>>
>> Hmm, using synchronous calls is not an option either. They're strongly
>> discouraged, and will throw warnings on some browsers.
>>
>> Can we not just have the first callback initiate the next call and so on?
>
>
> hmm.. Yes we achieved the same. Please find attached modified patch file.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company