Re: Remove freelist reference in buf_init.c

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: Remove freelist reference in buf_init.c
Дата
Msg-id qzat6eywgt6gxtprzyozdf36xgautuw5admtpjjjz2btx42ltr@4yagnl4rkwpy
обсуждение исходный текст
Ответ на Remove freelist reference in buf_init.c  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Ответы Re: Remove freelist reference in buf_init.c
Список pgsql-hackers
Hi,

On 2026-02-03 10:48:30 +0530, Ashutosh Bapat wrote:
> We have gotten rid of freelist in buffer manager, but buf_init.c still
> has a reference to it in a comment. Patch to remove the reference.
> 
> Other references to freelist refer to freelist.c which is still a
> valid filename reference. Hence I didn't touch it.

I'm not sure this enough of an improvement to really be worth it. I think we
probably ought to rename freelist.c to buf_replacement.c or such.  Which of
course will require more comment changes.

Even if we don't, I think that the entire comment in buf_init.c is misplaced
and bound to not be updated. Nobody is looking for it there, both when trying
to learn about the code and when changing the code.

Greetings,

Andres Freund



В списке pgsql-hackers по дате отправления: