Re: pgsql: Incorporate strerror_r() into src/port/snprintf.c, too.

On 26/09/2018 18:36, Tom Lane wrote:
> Incorporate strerror_r() into src/port/snprintf.c, too.
> 
> This provides the features that used to exist in useful_strerror()
> for users of strerror_r(), too.  Also, standardize on the GNU convention
> that strerror_r returns a char pointer that may not be NULL.

Somehow, this is not working for me:

Undefined symbols for architecture x86_64:
  "_libintl_gettext", referenced from:
      _pg_strerror_r in strerror.o
ld: symbol(s) not found for architecture x86_64
collect2: error: ld returned 1 exit status
make[4]: *** [../../../../src/Makefile.shlib:303: libpgtypes.3.12.dylib]
Error 1

It works if I don't use --enable-nls.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services