Clean up optional rules in grammar

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Clean up optional rules in grammar
Дата
Msg-id e9eed669-e32d-6919-fed4-acc0daea857b@enterprisedb.com
обсуждение исходный текст
Ответы Re: Clean up optional rules in grammar
Re: Clean up optional rules in grammar
Re: Clean up optional rules in grammar
Список pgsql-hackers
There are a number of rules like this in the grammar:

opt_foo: FOO
         | /*EMPTY*/
;

And there are some like this:

opt_foo: FOO         {}
         | /*EMPTY*/  {}
;

and some even like this:

%type <node> opt_foo

opt_foo: FOO         { $$ = NULL; }
         | /*EMPTY*/  { $$ = NULL; }
;

(I mean here specifically those rules where FOO is a noise word and the 
actions are the same in each branch.)

It's obviously confusing to have multiple different styles to do the 
same thing.  And these extra rules (including the empty ones) also end 
up in the output, so they create more work down the line.

The attached patch cleans this up to make them all look like the first 
style.

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Simon Riggs
Дата:
Сообщение: Re: Background writer and checkpointer in crash recovery
Следующее
От: "tsunakawa.takay@fujitsu.com"
Дата:
Сообщение: RE: Disable WAL logging to speed up data loading