Re: Clean up optional rules in grammar

Поиск
Список
Период
Сортировка
От John Naylor
Тема Re: Clean up optional rules in grammar
Дата
Msg-id CAFBsxsGD6AaUDOXyWnE=p8W0Ex0On5CJTMDQZMQP6Ry3oU-+7A@mail.gmail.com
обсуждение исходный текст
Ответ на Clean up optional rules in grammar  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Список pgsql-hackers

On Wed, Nov 11, 2020 at 5:13 AM Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
It's obviously confusing to have multiple different styles to do the
same thing.  And these extra rules (including the empty ones) also end
up in the output, so they create more work down the line.

The attached patch cleans this up to make them all look like the first
style.

+1 for standardizing in this area. It's worth noting that Bison 3.0 introduced %empty for this situation, which is self-documenting. Until we get there, this is a good step.

--
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Greg Sabino Mullane
Дата:
Сообщение: Re: Prefer TG_TABLE_NAME over TG_RELNAME in tests
Следующее
От: John Naylor
Дата:
Сообщение: Re: cutting down the TODO list thread