Re: Covering GiST indexes

От: Andreas Karlsson
Тема: Re: Covering GiST indexes
Дата: ,
Msg-id: e21a2957-2563-77b8-c332-619b32b4b65b@proxel.se
(см: обсуждение, исходный текст)
Ответ на: Re: Covering GiST indexes  (Andrey Borodin)
Ответы: Re: Covering GiST indexes  (Andreas Karlsson)
Re: Covering GiST indexes  (Andrey Borodin)
Список: pgsql-hackers

Скрыть дерево обсуждения

Covering GiST indexes  (Andrey Borodin, )
 Re: Covering GiST indexes  (Teodor Sigaev, )
  Re: Covering GiST indexes  (Aleksander Alekseev, )
  Re: Covering GiST indexes  (Andrey Borodin, )
   Re: Covering GiST indexes  (Andrey Borodin, )
    Re: Covering GiST indexes  (Thomas Munro, )
     Re: Covering GiST indexes  (Andrey Borodin, )
      Re: Covering GiST indexes  (Thomas Munro, )
       Re: Covering GiST indexes  (Andrey Borodin, )
        Re: Covering GiST indexes  (Dmitry Dolgov, )
         Re: Covering GiST indexes  (Andrey Borodin, )
          Re: Covering GiST indexes  (Andreas Karlsson, )
           Re: Covering GiST indexes  (Andrey Borodin, )
            Re: Covering GiST indexes  (Andreas Karlsson, )
             Re: Covering GiST indexes  (Andrey Borodin, )
              Re: Covering GiST indexes  (Andreas Karlsson, )
               Re: Covering GiST indexes  (Andreas Karlsson, )
               Re: Covering GiST indexes  (Andrey Borodin, )
                Re: Covering GiST indexes  (Andreas Karlsson, )
                 Re: Covering GiST indexes  (Andrey Borodin, )
                  Re: Covering GiST indexes  (Andreas Karlsson, )
                   Re: Covering GiST indexes  (Alexander Korotkov, )
                    Re: Covering GiST indexes  (Alexander Korotkov, )
                     Re: Covering GiST indexes  (Andrey Borodin, )
 Re: Covering GiST indexes  (Alexander Korotkov, )
  Re: Covering GiST indexes  (Darafei "Komяpa" Praliaskouski, )
   Re: Covering GiST indexes  (Alexander Korotkov, )
 Re: Covering GiST indexes  (Peter Geoghegan, )

Thanks for the new version of the patch. Based on my knowledge of PG 
this is starting to look good, and I have only three small comments below.

I am not 100% a fan of truncTupdesc, but as long as it is well commented 
I think that it is fine.

= Review

* I think it is worth writing a short comment when you create 
truncTupdesc about why this is done.

* Very minor thing: the diff below is pointless churn on a line not 
touched by the patch.

-                        values, isnull, true /* size is currently bogus 
*/ );
+                        values, isnull, true /* size is currently bogus 
*/);

* Another very minor thing: The diff below from gistFormTuple() should 
probably be consistent about brackets.

+           if (isnull[i])
+               compatt[i] = (Datum) 0;
+           else
+           {
+               compatt[i] = attdata[i];
+           }

Andreas



В списке pgsql-hackers по дате сообщения:

От: Andres Freund
Дата:
Сообщение: Re: COPY FROM WHEN condition
От: Michael Paquier
Дата:
Сообщение: Re: A few new options for vacuumdb