Re: Windows: openssl & gssapi dislike each other

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема Re: Windows: openssl & gssapi dislike each other
Дата
Msg-id d4afe789-7f01-4c46-b08d-f364f0cd5fad@dunslane.net
обсуждение исходный текст
Ответ на Re: Windows: openssl & gssapi dislike each other  (Dave Page <dpage@pgadmin.org>)
Ответы Re: Windows: openssl & gssapi dislike each other
Список pgsql-hackers


On 2024-06-11 Tu 05:19, Dave Page wrote:
Hi

On Sun, 9 Jun 2024 at 08:29, Imran Zaheer <imran.zhir@gmail.com> wrote:
Hi

I am submitting two new patches. We can undefine the macro at two locations

1). As be-secure-openssl.c [1] was the actual
file where the conflict happened so I undefined the macro here before
the ssl includes. I changed the comment a little to make it understandable.
I am also attaching the error generated with ninja build.

OR

2). Right after the gssapi includes in libpq-be.h

Thank you for working on this. I can confirm the undef version compiles and passes tests with 16.3.
 


Thanks for testing.

I think I prefer approach 2, which should also allow us to remove the #undef in sslinfo.c so we only need to do this in one place.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michail Nikolaev
Дата:
Сообщение: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY
Следующее
От: Jelte Fennema-Nio
Дата:
Сообщение: Re: Addressing SECURITY DEFINER Function Vulnerabilities in PostgreSQL Extensions