Re: elog(DEBUG2 in SpinLocked section.

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема Re: elog(DEBUG2 in SpinLocked section.
Дата
Msg-id c22c01ca-b128-df91-f7ef-5ec89525fee0@oss.nttdata.com
обсуждение исходный текст
Ответ на Re: elog(DEBUG2 in SpinLocked section.  (Amit Kapila <amit.kapila16@gmail.com>)
Ответы Re: elog(DEBUG2 in SpinLocked section.  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Список pgsql-hackers

On 2020/06/02 17:42, Amit Kapila wrote:
> On Tue, Jun 2, 2020 at 2:05 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> On 2020/06/02 16:15, Kyotaro Horiguchi wrote:
>>> Hello.
>>>
>>> I noticed that UpdateSpillStats calls "elog(DEBUG2" within
>>> SpinLockAcquire section on MyWalSnd.  The lock doesn't protect rb and
>>> in the first place the rb cannot be modified during the function is
>>> running.
>>>
>>> It should be out of the lock section.
> 
> Right.
> 
>>
>> Thanks for the patch! It looks good to me.
>>
> 
> The patch looks good to me as well.  I will push this unless Fujii-San
> wants to do it.

Thanks! I pushed the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: Resetting spilled txn statistics in pg_stat_replication
Следующее
От: Dilip Kumar
Дата:
Сообщение: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions