Re: Using defines for protocol characters

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: Using defines for protocol characters
Дата
Msg-id b9b949be-dff6-e75f-c95b-71afc70cfa5d@eisentraut.org
обсуждение исходный текст
Ответ на Re: Using defines for protocol characters  (Dave Cramer <davecramer@gmail.com>)
Ответы Re: Using defines for protocol characters  (Dave Cramer <davecramer@gmail.com>)
Список pgsql-hackers
1. As was discussed, these definitions should go into 
src/include/libpq/pqcomm.h, not a new file.

2. I would prefer an underscore after PgMsg, like PqMsg_DescribeRequest, 
so it's easier to visually locate the start of the actual message name.

3. IMO, the names of the protocol messages in protocol.sgml are 
canonical.  Your patch appends "Request" and "Response" in cases where 
that is not part of the actual name.  Also, some messages are documented 
to go both ways, so this separation doesn't make sense strictly 
speaking.  Please use the names as in protocol.sgml without augmenting them.




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ashutosh Bapat
Дата:
Сообщение: Re: Report planning memory in EXPLAIN ANALYZE
Следующее
От: David Rowley
Дата:
Сообщение: Re: Report planning memory in EXPLAIN ANALYZE