Re: Using defines for protocol characters

Поиск
Список
Период
Сортировка
От Dave Cramer
Тема Re: Using defines for protocol characters
Дата
Msg-id CADK3HHJgZWCh8Kwvc41=B3nAXyP_iX0bFewe7+7q6qp1hXiW5g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Using defines for protocol characters  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Ответы Re: Using defines for protocol characters  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Re: Using defines for protocol characters  (Peter Eisentraut <peter@eisentraut.org>)
Список pgsql-hackers


On Mon, 7 Aug 2023 at 16:50, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
> On Mon, Aug 07, 2023 at 04:02:08PM -0400, Tom Lane wrote:
>> Dave Cramer <davecramer@gmail.com> writes:
>>> On Mon, 7 Aug 2023 at 12:59, Robert Haas <robertmhaas@gmail.com> wrote:
>>>> PqMsgEmptyQueryResponse or something like that seems better, if we
>>>> want to keep the current capitalization. I'm not a huge fan of the way
>>>> we vary our capitalization conventions so much all over the code base,
>>>> but I think we would at least do well to keep it consistent from one
>>>> end of a certain identifier to the other.
>>
>>> I don't have a strong preference, but before I make the changes I'd like to
>>> get consensus.
>>> Can we vote or whatever it takes to decide on a naming pattern that is
>>> acceptable ?
>>
>> I'm good with Robert's proposal above.
>
> +1

+1.

Also we need to decide what to do with them:

> #define PQMSG_REQ_PREPARED 'S'
> #define PQMSG_REQ_PORTAL 'P'

If we go "PqMsgEmptyQueryResponse", probably we should go something
like for these?

#define PqMsgReqPrepared 'S'
#define PqMsgReqPortal 'P'

I went with PqMsgPortalSubCommand and PqMsgPreparedSubCommand 

See attached patch

Dave
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Support to define custom wait events for extensions
Следующее
От: Tatsuo Ishii
Дата:
Сообщение: Re: Using defines for protocol characters