Re: Improve logging when using Huge Pages

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема Re: Improve logging when using Huge Pages
Дата
Msg-id b707355a-84ba-9f8b-6026-8fac36121279@oss.nttdata.com
обсуждение исходный текст
Ответ на RE: Improve logging when using Huge Pages  ("Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>)
Список pgsql-hackers

On 2021/09/07 13:09, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
> Hello,
> 
> Thank you everyone for comments.
> In the thread [1] that Horiguchi told me about, there is already a review going on about GUC for HugePages memory.
> For this reason, I have removed the new GUC implementation and attached a patch that changes only the message at
instancestartup.
 

Thanks for updating the patch!

Even with the patch, there are still some cases where huge pages is
disabled silently. We should report something even in these cases?
For example, in the platform where huge pages is not supported,
it's silently disabled when huge_pages=try.

One big concern about the patch is that log message is always reported
when shared memory fails to be allocated with huge pages enabled
when huge_pages=try. Since huge_pages=try is the default setting,
many users would see this new log message whenever they start
the server. Those who don't need huge pages but just use the default
setting might think that such log messages would be noisy.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Nitin Jadhav
Дата:
Сообщение: Re: when the startup process doesn't (logging startup delays)
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: PROXY protocol support