Re: pg_upgrade test writes to source directory

On 25.05.22 09:25, Michael Paquier wrote:
>> It looks like an addition of
>>
>>      chdir $ENV{TESTOUTDIR};
>>
>> could fix it.  Please check the patch.
> I think that you mean TESTDIR, and not TESTOUTDIR?

I chose TESTOUTDIR because it corresponds to the tmp_check directory, so 
that the output files of the pg_upgrade run are removed when the test 
artifacts are cleaned up.  When using TESTDIR, the pg_upgrade output 
files end up in the build directory, which is less bad than the source 
directory, but still not ideal.