Re: pgsql: Add general purpose hasing functions to pgbench.
От | Fabien COELHO |
---|---|
Тема | Re: pgsql: Add general purpose hasing functions to pgbench. |
Дата | |
Msg-id | alpine.DEB.2.20.1803221728100.22230@lancre обсуждение исходный текст |
Ответ на | Re: pgsql: Add general purpose hasing functions to pgbench. (Teodor Sigaev <teodor@sigaev.ru>) |
Ответы |
Re: pgsql: Add general purpose hasing functions to pgbench.
|
Список | pgsql-committers |
> will fix, A blind attempt, if it helps. >> The 32-bit members of the buildfarm aren't very happy with this, >> eg on dromedary: >> >> cache gcc -Wall -Wmissing-prototypes -Wpointer-arith >> -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute >> -Wformat-security -fno-strict-aliasing -fwrapv -g -O2 -ansi -I. -I. >> -I../../../src/interfaces/libpq -I../../../src/include >> -DCOPY_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST -c -o command.o >> command.c >> pgbench.c: In function 'getHashFnv1a': >> pgbench.c:945: warning: integer constant is too large for 'long' type >> pgbench.c:952: warning: integer constant is too large for 'long' type >> pgbench.c: In function 'getHashMurmur2': >> pgbench.c:967: warning: integer constant is too large for 'long' type >> pgbench.c:970: warning: integer constant is too large for 'long' type >> pgbench.c:972: warning: integer constant is too large for 'long' type >> pgbench.c:975: warning: integer constant is too large for 'long' type >> pgbench.c:978: warning: integer constant is too large for 'long' type >> >> Looks to me like the constants need to be written with INT64CONST(). >> Also, the fact that the added regression test is passing makes me >> wonder whether it's actually exercising these functions meaningfully. I think that there is at least some coverage (https://coverage.postgresql.org/src/bin/pgbench/pgbench.c.gcov.html) and the function results are also checked for some values in the perl script output. -- Fabien.
Вложения
В списке pgsql-committers по дате отправления: