Re: [HACKERS] [WIP] Zipfian distribution in pgbench

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: [HACKERS] [WIP] Zipfian distribution in pgbench
Дата
Msg-id alpine.DEB.2.20.1711200647580.11926@lancre
обсуждение исходный текст
Ответ на Re: [HACKERS] [WIP] Zipfian distribution in pgbench  (Alik Khilazhev <a.khilazhev@postgrespro.ru>)
Ответы Re: [HACKERS] [WIP] Zipfian distribution in pgbench
Список pgsql-hackers
Hello Alik,

Patch applies with "patch", but not with "git apply", probably because it 
is in CR-NL eol format. No big deal.

Documentation has been switched from SGML to XML, so now tags must be 
explicitely closed, i.e. use <foo>x</foo> instead of <foo>x</>.

Patch compiles with a warning:

  pgbench.c: In function ‘getZipfianRand’:
  pgbench.c:905:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

Declaration must move before assertion.

The random_zipfian(1,100,2) call result is not tested.

"1 times" -> "once".

"array overflow on \random_zipfian" remove spurious "\".



-- 
Fabien.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Masahiko Sawada
Дата:
Сообщение: Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.
Следующее
От: Antonin Houska
Дата:
Сообщение: Re: [HACKERS] Proposal: generic WAL compression