Re: [HACKERS] [WIP] Zipfian distribution in pgbench

Поиск
Список
Период
Сортировка
От Alik Khilazhev
Тема Re: [HACKERS] [WIP] Zipfian distribution in pgbench
Дата
Msg-id 3EB1383F-4358-4131-8848-65EC7408B138@postgrespro.ru
обсуждение исходный текст
Ответ на Re: [HACKERS] [WIP] Zipfian distribution in pgbench  (Fabien COELHO <coelho@cri.ensmp.fr>)
Ответы Re: [HACKERS] [WIP] Zipfian distribution in pgbench
Список pgsql-hackers
> Patch applies with "patch", but not with "git apply", probably because it is in CR-NL eol format. No big deal.
>
> Documentation has been switched from SGML to XML, so now tags must be explicitely closed, i.e. use <foo>x</foo>
insteadof <foo>x</>. 
>
> Patch compiles with a warning:
>
> Declaration must move before assertion.
>
> "array overflow on \random_zipfian" remove spurious "\".

Fixed.

> The random_zipfian(1,100,2) call result is not tested.

I have reduced range to [1, 10] and updated the test.

> "1 times" -> "once”.

I am not sure that it need to be fixed in this way, because there can be another number instead of 1.
So, I updated it to “%d time(s)”


—
Thanks and Regards,
Alik Khilazhev
Postgres Professional:
http://www.postgrespro.com
The Russian Postgres Company



Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Aleksander Alekseev
Дата:
Сообщение: Re: Jsonb transform for pl/python
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: [HACKERS] Custom compression methods