Re: [HACKERS] merge psql ef/ev sf/sv handling functions

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: [HACKERS] merge psql ef/ev sf/sv handling functions
Дата
Msg-id alpine.DEB.2.20.1707181436150.4496@lancre
обсуждение исходный текст
Ответ на Re: [HACKERS] merge psql ef/ev sf/sv handling functions  (Victor Drobny <v.drobny@postgrespro.ru>)
Список pgsql-hackers
Hello Victor,

>> While reviewing Corey's \if patch, I complained that there was some
>> amount of copy-paste in "psql/command.c".
>> 
>> Here is an attempt at merging some functions which removes 160 lines of 
>> code.
>
> I was looking through your patch. It seems good, the of the functions was 
> very similar.

Indeed. I guess that it was initially a copy paste.

> I have a question for you. What was the reason to replace "printfPQExpBuffer" 
> by "resetPQExpBuffer" and "appendPQExpBufferStr"?

Because the "printf" version implies interpreting the format layer which 
does not add significant value compared to just appending the string.

-- 
Fabien.



В списке pgsql-hackers по дате отправления: