Re: [HACKERS] merge psql ef/ev sf/sv handling functions

Поиск
Список
Период
Сортировка
От Victor Drobny
Тема Re: [HACKERS] merge psql ef/ev sf/sv handling functions
Дата
Msg-id 3fcca87aa4eacdc5981a5b219530dc1f@postgrespro.ru
обсуждение исходный текст
Ответы Re: [HACKERS] merge psql ef/ev sf/sv handling functions  (Fabien COELHO <coelho@cri.ensmp.fr>)
Список pgsql-hackers
On 2017-03-31 21:04, Fabien COELHO wrote:
> Hello,
> 
> While reviewing Corey's \if patch, I complained that there was some
> amount of copy-paste in "psql/command.c".
> 
> Here is an attempt at merging some functions which removes 160 lines of 
> code.

Hello,

I was looking through your patch. It seems good, the of the functions 
was very similar.
I have a question for you. What was the reason to replace 
"printfPQExpBuffer" by "resetPQExpBuffer" and "appendPQExpBufferStr"?

Thank you for attention!

-- 
------
Victor Drobny
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [HACKERS] segfault in HEAD when too many nested functions call
Следующее
От: Alexey Chernyshov
Дата:
Сообщение: [HACKERS] [PATCH] Add citext_pattern_ops to citext contrib module