On 2020/03/16 11:09, Atsushi Torikoshi wrote:
> Hi,
>
> The current manual on CREATE TABLE[1] describes storage
> parameters with their types.
> But manual on CREATE INDEX[2] describes storage parameters
> WITHOUT their types.
>
> I think it'll be better to add types to storage parameters
> on CREATE INDEX for the consistency.
>
> Attached a patch.
> Any thought?
Thanks for the patch! It basically looks good to me.
- <term><literal>buffering</literal>
+ <term><literal>buffering</literal> (<type>string</type>)
Isn't it better to use "enum" rather than "string"?
In the docs about enum GUC parameters, "enum" is used there.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters