Re: update tuple routing and triggers

Поиск
Список
Период
Сортировка
От Amit Langote
Тема Re: update tuple routing and triggers
Дата
Msg-id ac8f87eb-eea5-bbd0-81f8-9d9a19aefd41@lab.ntt.co.jp
обсуждение исходный текст
Ответ на Re: update tuple routing and triggers  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: update tuple routing and triggers
Список pgsql-hackers
Thanks for the review.

On 2018/02/08 0:04, Robert Haas wrote:
> On Tue, Feb 6, 2018 at 12:52 AM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> About renaming es_leaf_result_relations to
>> es_tuple_routing_result_relations, I will defer that to committer.  But on
>> second though, maybe we don't need to make this patch larger than it has
>> to be.
> 
> +1 for renaming it.  I like keeping the patch small, but not at the
> price of being misleading.

OK, done in the attached.

> +            /*
> +             * Since we're newly creating this ResultRelInfo, add it to
> +             * someplace where others could find it.
> +             */
> 
> How about: "Since we've just initialized this ResultRelInfo, it's not
> in any list attached to the estate as yet.  Add it, so that it can be
> found later."

Wrote that way.

Thanks,
Amit

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: PostgreSQL crashes with SIGSEGV
Следующее
От: Robert Haas
Дата:
Сообщение: Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly