Re: update tuple routing and triggers

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: update tuple routing and triggers
Дата
Msg-id CA+TgmoZUGSOKNBq79HRJF7HKF1xnwthrp_Dpih+c3_Ft3hpo6Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: update tuple routing and triggers  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Ответы Re: update tuple routing and triggers
Список pgsql-hackers
On Tue, Feb 6, 2018 at 12:52 AM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> About renaming es_leaf_result_relations to
> es_tuple_routing_result_relations, I will defer that to committer.  But on
> second though, maybe we don't need to make this patch larger than it has
> to be.

+1 for renaming it.  I like keeping the patch small, but not at the
price of being misleading.

+            /*
+             * Since we're newly creating this ResultRelInfo, add it to
+             * someplace where others could find it.
+             */

How about: "Since we've just initialized this ResultRelInfo, it's not
in any list attached to the estate as yet.  Add it, so that it can be
found later."

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Steele
Дата:
Сообщение: Re: Re: [HACKERS] WIP: Separate log file for extension
Следующее
От: David Steele
Дата:
Сообщение: Re: Re: [HACKERS] PATCH: enabling parallel execution for cursorsexplicitly (experimental)