Re: Pluggable cumulative statistics
От | Bertrand Drouvot |
---|---|
Тема | Re: Pluggable cumulative statistics |
Дата | |
Msg-id | Zo5GSPe1UqAGBKrg@ip-10-97-1-34.eu-west-3.compute.internal обсуждение исходный текст |
Ответ на | Re: Pluggable cumulative statistics (Michael Paquier <michael@paquier.xyz>) |
Ответы |
Re: Pluggable cumulative statistics
|
Список | pgsql-hackers |
Hi, On Tue, Jul 09, 2024 at 03:54:37PM +0900, Michael Paquier wrote: > On Mon, Jul 08, 2024 at 02:07:58PM +0000, Bertrand Drouvot wrote: > > It looks pretty straightforward, just one comment: > > > > + ptr = ((char *) ctl) + kind_info->shared_ctl_off; > > + kind_info->init_shmem_cb((void *) ptr); > > > > I don't think we need to cast ptr to void when calling init_shmem_cb(). Looking > > at some examples in the code, it does not look like we cast the argument to void > > when a function has (void *) as parameter (also there is examples in 0003 where > > it's not done, see next comments for 0003). > > Yep. Fine by me. Thanks! > > Please find attached a rebased patch set for now, to make the > CF bot happy. v5-0001 LGTM. As far v5-0002: + goto error; + info = pgstat_get_kind_info(kind); Nit: add an empty line between the two? Except this Nit, v5-0002 LGTM. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
В списке pgsql-hackers по дате отправления: