Re: replace strtok()

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: replace strtok()
Дата
Msg-id Zni-_fUq49SNSyir@paquier.xyz
обсуждение исходный текст
Ответ на Re: replace strtok()  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: replace strtok()
Список pgsql-hackers
On Sat, Jun 22, 2024 at 11:48:21AM -0400, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
> > On 18.06.24 13:43, Ranier Vilela wrote:
> >> I found another implementation of strsep, it seems lighter to me.
> >> I will attach it for consideration, however, I have not done any testing.
>
> > Yeah, surely there are many possible implementations.  I'm thinking,
> > since we already took other str*() functions from OpenBSD, it makes
> > sense to do this here as well, so we have only one source to deal with.
>
> Why not use strpbrk?  That's equally thread-safe, it's been there
> since C89, and it doesn't have the problem that you can't find out
> which of the delimiter characters was found.

Yeah, strpbrk() has been used in the tree as far as 2003 without any
port/ implementation.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ranier Vilela
Дата:
Сообщение: Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c)
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c)