On Fri, Oct 27, 2023 at 02:44:42AM +0000, Fujii.Yuki@df.MitsubishiElectric.co.jp wrote:
> Hi Momjian.
>
> Thank you for your improvement.
> As a matter of detail, I think that the areas marked below are erroneous.
>
> --
> + Pushdown causes aggregate function cals to send partial aggregate
> ^
> + function calls to the remote server. If the partial aggregate
> + function doesn't doesn't exist on the remote server, it causes
> ^^^^^^^
> --
Agreed. Do you want to fix that on your vesion? I don't have any more
improvements to make.
> > What else needs to be done before committers start to review
> > this?
> There are no others. May I make a new version of v31 with your
> suggested improvements for the committer's review?
Yes, please. I think the updated docs will help people understand how
the patch works.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.