Re: Fix proposal for comparaison bugs in PostgreSQL::Version

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Fix proposal for comparaison bugs in PostgreSQL::Version
Дата
Msg-id YruoymSg9OQJb7QP@paquier.xyz
обсуждение исходный текст
Ответ на Re: Fix proposal for comparaison bugs in PostgreSQL::Version  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-hackers
On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote:
> Nice catch, but this looks like massive overkill. I think we can very
> simply fix the test in just a few lines of code, instead of a 190 line
> fix and a 130 line TAP test.
>
> It was never intended to be able to compare markers like rc1 vs rc2, and
> I don't see any need for it. If you can show me a sane use case I'll
> have another look, but right now it seems quite unnecessary.
>
> Here's my proposed fix.

Do you think that we should add some tests for that?  One place that
comes into mind is test_misc/, and this would be cheap as this does
not require setting up a node or such.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Export log_line_prefix(); useful for emit_log_hook.
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: better error description on logical replication