Re: convert elog(LOG) calls to ereport

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: convert elog(LOG) calls to ereport
Дата
Msg-id X8iNn/Da5xHf1dul@paquier.xyz
обсуждение исходный текст
Ответ на Re: convert elog(LOG) calls to ereport  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: convert elog(LOG) calls to ereport  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Список pgsql-hackers
On Wed, Dec 02, 2020 at 11:04:45AM -0300, Alvaro Herrera wrote:
> Please take the opportunity to move the flag name out of the message in
> this one, also.  I do wonder if it'd be a good idea to move the syscall
> name itself out of the message, too; that would reduce the number of
> messages to translate 50x to just "%s(%s) failed: %m" instead of one
> message per distinct syscall.

+1.

+   else
+       ereport(LOG,
+               (errmsg("checkpoint starting:%s%s%s%s%s%s%s%s",

Would it be better to add a note for translators here, in short that
all those %s are options related to checkpoint/restartpoints?

The ones in geqo_erx.c look like debugging information, and the ones
in win32_shmem.c for segment creation are code paths only used by the
postmaster.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thomas Munro
Дата:
Сообщение: Re: Commitfest 2020-11 is closed
Следующее
От: "tsunakawa.takay@fujitsu.com"
Дата:
Сообщение: RE: [Patch] Optimize dropping of relation buffers using dlist