Re: more i18n/l10n issues

Alvaro Herrera writes:

> #: utils/misc/guc.c:647
> msgid "collect statistics about executing commands"
>
> Is this really "statistics" about the executing commands?

Looks like it.

> #: utils/misc/guc.c:892
> msgid ""
> "The number must be a positive integer. If 0 is specified then effort * "
> "log2(poolsize) is used"
>
> Is it missing the final dot?

Added.

> #: commands/tablecmds.c:2029
> msgid "column \"%s\" is in a primary key"
>
> So, is it in A primary key, or THE primary key?

The message doesn't mention a table, so "the primary key" would just stand
without reference.  I think both have merits.

> #: commands/tablecmds.c:4093
> msgid "relation \"%s\" already has a TOAST table"
>
> This is the one place where I found it could be table instead of
> relation, because it's checked explicitly in the code.

True.  I've also changed a few messages around that one.

> The postmaster executable shows --help display perfectly localized.
> However I just noted that postgres --help output (the standalone
> backend) does not; is it not i18n'ed, or is some sort of missetup?

It was not set up for gettext, but it is now.

-- 
Peter Eisentraut   peter_e@gmx.net