On Wed, Dec 8, 2021 7:52 PM Ajin Cherian <itsajin@gmail.com> wrote:
> On Tue, Dec 7, 2021 at 5:36 PM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > We were mid-way putting together the next v45* when your latest
> > attachment was posted over the weekend. So we will proceed with our
> > original plan to post our v45* (tomorrow).
> >
> > After v45* is posted we will pause to find what are all the
> > differences between your unified patch and our v45* patch set. Our
> > intention is to integrate as many improvements as possible from your
> > changes into the v46* etc that will follow tomorrow’s v45*. On some
> > points, we will most likely need further discussion.
>
>
> Posting an update for review comments, using contributions majorly from
> Peter Smith.
> I've also included changes based on Euler's combined patch, specially changes
> to documentation and test cases.
> I have left out Hou-san's 0005, in this patch-set. Hou-san will provide a rebased
> update based on this.
Attach the Top up patch(as 0006) which do the replica identity validation when
actual UPDATE/DELETE happen. I adjusted the patch name to make the change
clearer.
The new version top up patch addressed all comments from Peter[1] and Greg[2].
I also fixed a validation issue of the top up patch reported by Tang. The fix
is: If we add a partitioned table with filter and pubviaroot is true, we need
to validate the parent table's row filter when UPDATE the child table and we
should convert the parent table's column to the child's during validation in
case the column order of parent table is different from the child table.
[1] https://www.postgresql.org/message-id/CAHut%2BPuBdXGLw1%2BCBoNxXUp3bHcHcKYWHx1RSGF6tY5aSLu5ZA%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAJcOf-dgxGmRs54nxQSZWDc0gaHZWFf3n%2BBhOChNXhi_cb8g9A%40mail.gmail.com
Best regards,
Hou zj