On Wednesday, September 6, 2023 11:18 AM Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com> wrote:
>
> On Tuesday, September 5, 2023 3:35 PM Kuroda, Hayato/黒田 隼人
> <kuroda.hayato@fujitsu.com> wrote:
>
> 4.
> + * XXX: As mentioned in comments atop get_output_plugins(), we may
> not
> + * have to consider the uniqueness of entries. If so, we can use
> + * count_old_cluster_logical_slots() instead of plugin_list_length().
> + */
>
> I think check_loadable_libraries() will avoid loading the same library, so it seems
> fine to skip duplicating the plugins and we can save some codes.
Sorry, there is a typo, I mean "deduplicating" instead of " duplicating "
>
> ----
> /* Did the library name change? Probe it. */
> if (libnum == 0 || strcmp(lib, os_info.libraries[libnum -
> 1].name) != 0)
> ----
>
> But if we think duplicating them would be better, I feel we could use the
Here also " duplicating " should be "deduplicating".
Best Regards,
Hou zj