Re: pg_basebackup: Always return valid temporary slot names

Поиск
Список
Период
Сортировка
От Nishant Sharma
Тема Re: pg_basebackup: Always return valid temporary slot names
Дата
Msg-id CADrsxdbSxz+wtpyFirbtPV6=GbCsU5rtzKUwWzv2XAuDdg8hWQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pg_basebackup: Always return valid temporary slot names  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers
Дерево обсуждения
On Tue, Sep 5, 2023 at 4:40 PM Jelte Fennema <me@jeltef.nl> wrote:
I modified the PgBouncer PR to always set the sign bit to 0. But I
still I think it makes sense to also address this in pg_basebackup.
 
Sounds good to me. Thank you!


On Tue, Sep 5, 2023 at 5:36 PM Daniel Gustafsson <daniel@yesql.se> wrote:
Since the value in the temporary slotname isn't used to convey meaning, but
merely to ensure uniqueness, I don't think it's unreasonable to guard aginst
malformed input (ie negative integer).

 Ok. In this case, I also agree.


+1 to the patch from my side. Thank you!


Regards,
Nishant.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Zhijie Hou (Fujitsu)"
Дата:
Сообщение: RE: [PoC] pg_upgrade: allow to upgrade publisher node
Следующее
От: jian he
Дата:
Сообщение: Re: Wrong rows estimations with joins of CTEs slows queries by more than factor 500