Re: PGA3 Memory Leaks

Поиск
Список
Период
Сортировка
От efesar
Тема Re: PGA3 Memory Leaks
Дата
Msg-id NGBBKFMOILMAGDABPFEGMEALEEAA.efesar@nmia.com
обсуждение исходный текст
Ответ на Re: PGA3 Memory Leaks  (Andreas Pflug <Andreas.Pflug@web.de>)
Список pgadmin-hackers
> PLEASE undo your undos. The code will CRASH on GTK before the settings
> are written. I didn't go into detail which line is the offending one.
> Memory leaks on program exit is a waste of brain in my opinion. The
> operating system will do all cleanup for us.
> Since there are no trees, menues and so on destroyed and dynamically
> recreated, we don't need to care what's happening to those at the time
> of program end. And at last: I wouldn't have touched that code if
> it worked!

Andreas,

The wxWindows documentation specifically states those objects must be
deleted.

The one line I didn't uncomment was "delete statistics." Since statistics is
a wxListCtrl, it probably doesn't need to be deleted. That's why I left it
commented. Please test and document. It's possible your crash was caused by
that.

In the meantime, I think the change should stay. IMHO, memory leaks are not
wastes of time.

Dave -- Opinion? I'll leave this one up to you, it that's okay.

-Keith


В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Andreas Pflug
Дата:
Сообщение: Re: PGA3 Memory Leaks
Следующее
От: Andreas Pflug
Дата:
Сообщение: Re: PGA3 Memory Leaks