On Tue, 29 Apr 2025 at 16:53, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> On 2025-Apr-29, Japin Li wrote:
>
>> My understanding, based on the src/bin/pg_dump tests, is that they don't
>> involve a genuine restore of the dumped data to a database. Instead, it
>> dumps to a file using pg_restore. Is that correct?
>
> Yes.
>
>> I doubt whether I can add a test to pg_dump that would cover this issue.
>
> The pg_upgrade now includes a roundtrip dump/restore which you can take
> advantage of. You just need to ensure some of the src/test/regress/sql
> files leave an object in the state you need, and the pg_upgrade test
> will run those tests and try to dump and restore the resulting database.
>
Thank you for the explanation. A test case has been added to create_index.sql.
Could you please take a look?
--
Regrads,
Japin Li