> -----Original Message-----
> From: Jean-Michel POURE [mailto:jm.poure@freesurf.fr]
> Sent: 20 February 2002 10:20
> To: Dave Page
> Subject: Re: [pgadmin-hackers] To-Do List
>
>
> Le Mercredi 20 Février 2002 11:13, Dave Page a écrit :
> > Fixed that (you forgot to reset the tag on txtProperties(0)
> at the end
> > of frmView.Initialise.
> >
> > I'm just working on rename (which is slightly broken now
> :-( ) at the
> > moment...
>
> OK, thanks. Seems like I am a little kid breaking
> everything...
There's over 30,000 lines of code in there now. I'm not at all surprised
that you need a while to get familiar with it.
Anyhoo, rename wasn't broken - pgAdmin had started an instance of the old
compiled pgSchema, rather than the version I thought I was running in the
debugger.
It works now anyway (and is checked in). As I said above, you had forgotten
to reset the tags (which we use a 'dirty' flags) at the end of the
Initialise sub. I can see 2 outstanding issues at the moment:
1) Rollback in case of failure is not yet enabled (or tested?)
2) The new OID is not yet retrieved.
I also noticed that following a 'Refresh Below' on the Views icon, the
comment for a view on which the definition has been changed vanishes. We
should probably invalidate the comment cache after the drop/recreate.
Regards, Dave.