pgsql: Improve log pattern detection in recently-added TAP tests

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема pgsql: Improve log pattern detection in recently-added TAP tests
Дата
Msg-id E1lrxA2-0003R9-0f@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Improve log pattern detection in recently-added TAP tests

ab55d74 has introduced some tests with rows found as missing in logical
replication subscriptions for partitioned tables, relying on a logic
with a lookup of the logs generated, scanning the whole file.  This
commit makes the logic more precise, by scanning the logs only from the
position before the key queries are run to the position where we check
for the logs.  This will reduce the risk of issues with log patterns
overlapping with each other if those tests get more complicated in the
future.

Per discussion with Tom Lane.

Discussion: https://postgr.es/m/YMP+Gx2S8meYYHW4@paquier.xyz
Backpatch-through: 13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bfd96b7a3dc26a8384d4185d274573fb6a46b033

Modified Files
--------------
src/test/subscription/t/001_rep_changes.pl |  7 ++++++-
src/test/subscription/t/013_partition.pl   | 14 ++++++++++++--
2 files changed, 18 insertions(+), 3 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: pgsql: Improve and cleanup ProcArrayAdd(), ProcArrayRemove().
Следующее
От: Michael Paquier
Дата:
Сообщение: pgsql: Simplify some code in getObjectTypeDescription()